Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-15 Thread Landry Breuil
On Fri, Dec 15, 2017 at 08:22:32PM +0300, Victor Kukshiev wrote: > Landry: > > > Maybe stating the obvious, but have you tried building the ports > > depending on it ? at least x11/kde4/ffmpegthumbs & multimedia/mediatomb > > .. > > kde4-ffmpegthumbs is not depending on ffmpegthumbnailer. other p

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-15 Thread Victor Kukshiev
Landry: > Maybe stating the obvious, but have you tried building the ports > depending on it ? at least x11/kde4/ffmpegthumbs & multimedia/mediatomb > .. kde4-ffmpegthumbs is not depending on ffmpegthumbnailer. other ports build is ok.

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Stuart Henderson
On 2017/12/14 15:54, Landry Breuil wrote: > On Thu, Dec 14, 2017 at 05:38:46PM +0300, Victor Kukshiev wrote: > > Hello! I updated fmpegthumbnailer to 2.2.0 (switch build system to cmake) > > and take maintainership. > > ok? > > I think you forgot to cvs add a patch, and you should have a look at >

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Landry Breuil
On Thu, Dec 14, 2017 at 11:01:46PM +0300, Victor Kukshiev wrote: > Landry > > Lots of symbols were added/removed in libffmpegthumbnailer so you should > > bump the library major (ie 5.0 in SHARED_LIBS) otherzise it looks good > > here (at least it builds, but not that it fails to build if the previ

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Victor Kukshiev
Landry > Lots of symbols were added/removed in libffmpegthumbnailer so you should > bump the library major (ie 5.0 in SHARED_LIBS) otherzise it looks good > here (at least it builds, but not that it fails to build if the previous > version is installed) I fixed this. Thanks to review! Index: M

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Landry Breuil
On Thu, Dec 14, 2017 at 09:18:58PM +0300, Victor Kukshiev wrote: > Landry Brad > > I think you forgot to cvs add a patch, and you should have a look atGH_* > variables if using github as a new upstream. This way you'll avoid setting > MASTER_SITES, DISTNAME, EXTRACT_SUFX... > > I fixed. ok? Lots

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Victor Kukshiev
Landry Brad > I think you forgot to cvs add a patch, and you should have a look atGH_* variables if using github as a new upstream. This way you'll avoid setting MASTER_SITES, DISTNAME, EXTRACT_SUFX... I fixed. ok? Index: Makefile ==

Re: [UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Landry Breuil
On Thu, Dec 14, 2017 at 05:38:46PM +0300, Victor Kukshiev wrote: > Hello! I updated fmpegthumbnailer to 2.2.0 (switch build system to cmake) > and take maintainership. > ok? I think you forgot to cvs add a patch, and you should have a look at GH_* variables if using github as a new upstream. This

[UPDATE] ffmpegthumbnailer 2.2.0

2017-12-14 Thread Victor Kukshiev
Hello! I updated fmpegthumbnailer to 2.2.0 (switch build system to cmake) and take maintainership. ok? ? patches/patch-CMakeLists_txt Index: Makefile === RCS file: /cvs/ports/graphics/ffmpegthumbnailer/Makefile,v retrieving revision 1.