D8827: experimental support for auto mnemonics

ratijas added inline comments. INLINE COMMENTS > broulik wrote in Button.qml:43 > How does it behave if text contains an `&&` ie. user explicitly wants an > ampersand but not a mnemonic? So, it has landed, and it is still broken with respect to `&&`. I filed a bug report about it: https://bugs

D10523: Fix warnings

ratijas added inline comments. INLINE COMMENTS > ApplicationHeader.qml:278 > +target: delegateLoader.page > +Component.onDestruction: delegateLoader.sourceComponent > = null > +} Component attached object is a very special type in QML. It

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

ratijas added inline comments. INLINE COMMENTS > UpdatesPage.qml:262 > Layout.fillWidth: true > -elide: Text.ElideRight > +elide: truncated ? Text.ElideLeft : > Text.ElideRight > tex

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

ratijas added inline comments. INLINE COMMENTS > ratijas wrote in UpdatesPage.qml:262 > WAT > > how that is supposed to work OK, so that's a "multi-length string" feature using Unicode "String Terminator" character U009C, as described in QtQuick documentation: https://doc.qt.io/qt-6/qml-q

D25425: header property for the drawer

ratijas added inline comments. INLINE COMMENTS > GlobalDrawer.qml:339 > +Layout.fillWidth: true > +visible: contentItem && opacity > 0 > +Layout.preferredHeight: implicitHeight * opacity What is this contentItem referring to? I'm lookin

D25425: header property for the drawer

ratijas added inline comments. INLINE COMMENTS > ratijas wrote in GlobalDrawer.qml:339 > What is this contentItem referring to? I'm looking into a bug that header > does not collapse when the custom header Item is set to be invisible (search > field in Discover). Fixed in https://invent.kde.or

D7939: ColorSet concept in Theme

ratijas added inline comments. INLINE COMMENTS > platformtheme.h:223-224 > +Q_SIGNALS: > +//TODO: parameters to signals as this is also a c++ api > +void colorsChanged(); > +void defaultFontChanged(const QFont &font); What was this TODO all about? REPOSITORY R169 Kirigami REVISIO

D29694: Introduce Avatar component

ratijastk added a comment. Cool thing. Makes me think of Nintendo Mii, and their open source counterpart, bloke (which is not really used anywhere, but whatever). Also, can we have name resolution algorithm extracted elsewhere, in a more re-usable

D19745: Fix system tray UI/UX & refactor

ratijastk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ratijastk requested review of this revision. REVISION SUMMARY System tray widget had the following UX problem: Icons are laid out in a Flow QML layout, using minimal amount of space, thu

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. In D19745#430695 , @anthonyfieroni wrote: > Video or screenshot will be helpful. Here they are, "debug" mode via colored rectangles with `anchors.fill: parent`. F6690427: old.mp4

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. In D19745#430958 , @ngraham wrote: > Pretty nice stuff! While you're at it, how about implementing a UI change so that while the popup is open, its contents change as you slide the mouse along the icons (but only when

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Hello, Any progress on this one? Does it usually take long to review? Sorry for impatience. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik Cc: ngraham, ndavis, anthonyfieroni,

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. I'm afraid the more we wait, the more code base is diverging, which will require more patches for this pull request to be accepted. Btw, I'm still stuck with pinning old version in my package manager. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. My parent commit was `169238848136`; current master is `f8d5e1a2`. While on master, I am doing `git diff --summary 169238848136`. There is no intersection in changed files with my pull request. Still patch (as you aforementioned) can not be applied to master with

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Oh, nevermind. I forgot I should be using `arc` indeed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragr

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. So, I've merged done git rebase on master — just one conflicting line, rewritten after me in a better way. But now I have no way to test it, because CMake Error `Could not find a configuration file for package "ECM" that is compatible with requested version "5.58.

D19745: Fix system tray UI/UX & refactor

ratijastk added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:66 > Not really. > Using objectNames is a bit of an anti pattern, especially when QML has so the > built-in component scope hierachy. > > We use it in the system tray already, and it's arguably no worse than the

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. ~~Even with extra-cmake-modules 5.58, kcoreaddons needs to be updated as well... work in progress... please, be patient: i have autism^W slow hardware.~~ 5.58.0 releases just rolled out, upgrading... REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D19745: Fix system tray UI/UX & refactor

ratijastk updated this revision to Diff 58123. ratijastk added a comment. Rebase on most recent master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19745?vs=53851&id=58123 BRANCH fix-system-tray REVISION DETAIL https://phabricator.kde.org/D

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Double checked on my system. Nothing bad happened so far. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Bump (again) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. @davidedmundson Thanks. It is my first contribution to KDE/Plasma, so I **do hope** that I don't have a commit access. INLINE COMMENTS > davidedmundson wrote in CompactApplet.qml:34 > You will enter this branch if the system tray is on the left. > > It d

D19745: Fix system tray UI/UX & refactor

ratijastk added inline comments. INLINE COMMENTS > broulik wrote in AbstractItem.qml:22 > You sure this high version number is neccessary? Not exactly. But old layouts used to have a load of restrictions, for sure. > broulik wrote in AbstractItem.qml:30 > Avoid doing negated disjunctions for cl