jakobkummerow created this revision.
jakobkummerow added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jakobkummerow requested review of this revision.
REVISION SUMMARY
Getting CPU information starts with reading /proc/cpuinfo into a buffer;
jakobkummerow added a comment.
cfeck: Sure, an even better long-term fix would be to stop depending on a
hard-coded buffer size. Interleaved reading and parsing would be one way to
achieve that; another way would be a dynamic buffer size: start small, and if
it's too small then allocate a ne
jakobkummerow updated this revision to Diff 75616.
jakobkummerow retitled this revision from "Linux/cpuinfo.c: bump CPUINFOBUFSIZE
for 12+ core CPUs" to "Linux/cpuinfo.c: grow buffer size as needed for 12+ core
CPUs".
jakobkummerow edited the summary of this revision.
jakobkummerow added a commen
jakobkummerow updated this revision to Diff 75617.
jakobkummerow added a comment.
Minor update: size_t instead of int.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27362?vs=75616&id=75617
REVISION DETAIL
https://phabricator.kde.org/D27362
AFFECTED FILES
ksysguardd/Linux/cpuin
jakobkummerow added a comment.
ahiemstra: Thanks! I don't have commit access, so I'd appreciate it if you
could land this for me.
cfeck: Yes, realloc might be a nice improvement (if you think it even matters
for this case). Wanna submit a followup PR?
REVISION DETAIL
https://phabricat
jakobkummerow added a comment.
Thanks for landing this! My name is Jakob Kummerow, email:
jakob.kumme...@gmail.com
I created the diff via Phabricator's web interface (uploading a .diff file),
would have expected it to take the author information from my account...
REPOSITORY
jakobkummerow added a comment.
Thank you!
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D27362
To: jakobkummerow, davidedmundson, ahiemstra
Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB
