D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3

2018-10-27 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 beta 3 (authored by arojas). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16443?vs=4426

D4034: Show descriptive text when changing containment plugins

2018-10-27 Thread Root
rooty added a comment. hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davided

D16425: Added new Suspend then Hibernate option

2018-10-27 Thread Alejandro Valdes
avaldes updated this revision to Diff 44294. avaldes added a comment. I have added a new checkbox inside the suspend session delay and in button event handling. I wasn't able to make it work with the button event handling, but the checkbox does work with the logic when Suspend Session is

D14949: Add option for whether to show the volume change OSD

2018-10-27 Thread Alassane Maiga
amaiga added a comment. Yes! Please. I also struggle to understand what is the rationale for having something this big in the middle of the screen. Its not only distracting when watching movies playing games etc, but also while writing a report or just while basically doing anything that i

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-10-27 Thread Vlad Zagorodniy
zzag added a comment. Landing it... REPOSITORY R31 Breeze BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-10-27 Thread Vlad Zagorodniy
zzag closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-10-27 Thread Fabian Vogt
fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. Fails to build the KDE4 version here: [ 76s] /home/abuild/rpmbuild/BUILD/breeze-5.14.80git.20181027T152517~f1e4f103/libbreezecommon/breezeboxshadowrenderer.cpp:29:10: fatal error: Qt

D16459: Fix build of libbreezecommon with USE_KDE4

2018-10-27 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Breeze, zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY includes were incompatible. TEST PLAN Built it. REPOSITORY R31 Breeze BRANCH master REVIS

D16459: Fix build of libbreezecommon with USE_KDE4

2018-10-27 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D16459 To: fvogt, #breeze, zzag Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D16459: Fix build of libbreezecommon with USE_KDE4

2018-10-27 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R31:663ef0c694b3: Fix build of libbreezecommon with USE_KDE4 (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16459?vs=44305&id=44306 REVISION DETAIL

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-10-27 Thread Vlad Zagorodniy
zzag closed this revision. zzag added a comment. It's fixed now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma, #breeze, #vdg, ngraham Cc: fvogt, cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j

[frameworks-kio] [Bug 368008] Using a DAV filesystem, Dolphin fails to delete a file containing a ยต

2018-10-27 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=368008 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org,

D13100: do not use buffered file IO

2018-10-27 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:696 > const While this is "just an int", my personal taste is very much against using const on a file descriptor as this is not how this really works. I don't know. > aacid wrote in pam_kwallet.c:704 > const ACK REVI

D16425: Added new Suspend then Hibernate option

2018-10-27 Thread Nathaniel Graham
ngraham added a comment. We'll need a spinbox to display time options for the amount of delay before hibernating if this is the UI we go with. But I kinda like Martin's idea and present this in the form of an additional control sort of like this: While suspended, hibernate after: [comb

D4034: Show descriptive text when changing containment plugins

2018-10-27 Thread Nathaniel Graham
ngraham added a comment. In D4034#349125 , @rooty wrote: > hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency You are

D16425: Added new Suspend then Hibernate option

2018-10-27 Thread Alejandro Valdes
avaldes added a comment. In D16425#349588 , @ngraham wrote: > We'll need a spinbox to display time options for the amount of delay before hibernating if this is the UI we go with. But I kinda like Martin's idea and present this in the form of an