D8598: FolderView: position files at drop event target position

2017-11-05 Thread Eike Hein
hein added a comment. This looks quite good to me now - the fact that it's much shorter than my old attempt feels pretty nice ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, a

D8594: [platforms/drm] Rotate screen if requested from KScreen

2017-11-05 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b2d8bbec8157: [platforms/drm] Rotate screen if requested from KScreen (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8594?vs=21705&id=21889 R

D8627: [platforms/drm] Properly adjust cursor position on a rotated output

2017-11-05 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:c06c234778f8: [platforms/drm] Properly adjust cursor position on a rotated output (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8627?vs=21792

D8602: [platforms/drm] Restore previous mode if an atomic test fails

2017-11-05 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:26cdfd317fc8: [platforms/drm] Restore previous mode if an atomic test fails (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8602?vs=21725&id=21

D8661: Allow a cross-process check for same applications

2017-11-05 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R108:5d9027b110be7510a75daa789402b83c106a4164 introduced a r

D8663: Force Software QtQuick rendering when starting with QPainter compositor

2017-11-05 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If KWin/Wayland starts up with the QPainter compositor we force software rendering in QtQuick.

D8663: Force Software QtQuick rendering when starting with QPainter compositor

2017-11-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH software-qtquick-on-pqainter REVISION DETAIL https://phabricator.kde.org/D8663 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolf

D8663: Force Software QtQuick rendering when starting with QPainter compositor

2017-11-05 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:53f6a337bf41: Force Software QtQuick rendering when starting with QPainter compositor (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8663?vs=2

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far all outputs shared the same dumb buffer for the cursor image. This doesn't work any more

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread Martin Flöser
graesslin added a comment. What's now clearly to see is that the cursor hotspot is wrong. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8664 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreute

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread Martin Flöser
graesslin updated this revision to Diff 21917. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. We need to mirror both x and y REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8664?vs=21906&id=21917 BRANCH drm-cur

D8668: [platforms/drm] Fix cursor hotspot for inverted landscape rotation

2017-11-05 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change fixes the hotspot calculation by introducing a dedicated matrix to map the hotspot.

D8668: [platforms/drm] Fix cursor hotspot for inverted landscape rotation

2017-11-05 Thread Martin Flöser
graesslin added a dependency: D8664: [platforms/drm] Move cursor dumb buffers to Output. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8668 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterber

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread Martin Flöser
graesslin added a dependent revision: D8668: [platforms/drm] Fix cursor hotspot for inverted landscape rotation. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8664 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Idea is good. Few minor comments. I might be wrong, but it looks to me that: updateCursor now swaps m_cursorIndex which is a signifcant behaviour

D8668: [platforms/drm] Fix cursor hotspot for inverted landscape rotation

2017-11-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drm-cursor-hotspot REVISION DETAIL https://phabricator.kde.org/D8668 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliez

D8659: Make config window fit all controls

2017-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8659 To: ngraham, #kde_applications, davidedmundson, broulik, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali

D8659: Make config window fit all controls

2017-11-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R124:4c2f98ab8dcd: Make config window fit all controls (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8659?vs=21888&id=21923 REVISION DET

D8664: [platforms/drm] Move cursor dumb buffers to Output

2017-11-05 Thread Martin Flöser
graesslin added a comment. > updateCursor now swaps m_cursorIndex which is a signifcant behaviour change from the old separate setCursor/updateCursor Yes, I did it on purpose as I found the code usage weird and difficult to follow. I thought it's much easier to understand if we go for sw

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-11-05 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I don't have any objections to this revision. If you used one of the suggested colors for text. Let's go for the change. REPOSITORY R31 Breeze BRANCH arcpatch-D7424 REVISION DETAIL

D8673: Sanitize signal handling in ksmserver

2017-11-05 Thread Jiří Paleček
jpalecek created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The TERM signal handling in ksmserver invokes functions which are not async-signal safe, like Qt functions and C++ destructors. Moreover,

D8673: Sanitize signal handling in ksmserver

2017-11-05 Thread Jiří Paleček
jpalecek edited the summary of this revision. jpalecek added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8673: Sanitize signal handling in ksmserver

2017-11-05 Thread Jiří Paleček
jpalecek edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-11-05 Thread Nathaniel Graham
ngraham added a comment. Does anybody have any comments, concerns, or objections, or am I clear to land this? If so, it would be good to queue up approval for https://phabricator.kde.org/D859 too, and once both of those are in, I will update the color HIG wiki page