[Differential] [Request, 4 lines] D3356: [Windowed Widgets Runner] Don't access invalid KPluginMetaData

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 372017 FIXED-IN: 5

[Differential] [Closed] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS00369ec41315: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text (authored by broulik). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://ph

[Differential] [Updated, 7 lines] D3301: [libtaskmanager] Expose process ID of application

broulik retitled this revision from "WIP: [libtaskmanager] Expose process ID of application" to "[libtaskmanager] Expose process ID of application". broulik updated this revision to Diff 8130. broulik added a comment. Use KWindowInfo::pid() of Review 129362 REPOSITORY rPLASMAWORKSPACE Plasm

[Differential] [Requested Changes To] D3301: [libtaskmanager] Expose process ID of application

hein requested changes to this revision. hein added a reviewer: hein. hein added a comment. This revision now requires changes to proceed. Can you add the role to WaylandTasksModel::data() with a FIXME comment similar to other ones there? It's useful to me to grep for TODOs. REPOSITORY rPLA

[Differential] [Updated, 9 lines] D3301: [libtaskmanager] Expose process ID of application

broulik updated this revision to Diff 8131. broulik added a comment. Add FIXME comment to WaylandTasksModel REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3301?vs=8130&id=8131 REVISION DETAIL https://phabricator.kde.org/D3301 AFFECT

Re: [Discussion] - Plasma Panels Future Enhancements?

On Saturday 12 November 2016, Michail Vourlakos wrote: > Binding { > target: panel > property: "maskArea" > when: panelClient && panelClient.maskArea!==undefined > value: { > if (!panelClient || !panelClient.maskArea) { > return

[Differential] [Accepted] D3301: [libtaskmanager] Expose process ID of application

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3301 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3159: Set wayland output scale

graesslin added inline comments. INLINE COMMENTS > x11windowed_backend.cpp:201-205 > +//generally we don't need to normalise input to the output > scale; however because we're getting input > +//from a host window that doesn't understand scaling, we need to > apply it ou

[Differential] [Closed] D3301: [libtaskmanager] Expose process ID of application

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb5a83d08504d: [libtaskmanager] Expose process ID of application (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Request, 2 lines] D3357: Don't register a new service for screenshots

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If you're going to have kwin in the service name anyway there's absolutely no benefit to h

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 434 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/434/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Nov 2016 11:46:54 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/435/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Nov 2016 12:30:39 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/435/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Nov 2016 12:30:39 + Build duration: 1 min 37 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: [Discussion] - Plasma Panels Future Enhancements?

On 14/11/2016 12:11 μμ, Marco Martin wrote: On Saturday 12 November 2016, Michail Vourlakos wrote: Binding { target: panel property: "maskArea" when: panelClient && panelClient.maskArea!==undefined value: { if (!panelClient || !panelC

[Differential] [Closed] D3320: Avoid connecting to screen changed signals twice

davidedmundson closed this revision. davidedmundson added a comment. Pushed with https://phabricator.kde.org/rPLASMAWORKSPACE8a472f17ce11f3b79d740cdc21096d82b8683f3d REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3320 EMAIL PREFERENCES https:

Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

[Differential] [Accepted] D3356: [Windowed Widgets Runner] Don't access invalid KPluginMetaData

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3356 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100834 --- src/kpackagetool/kpackagetool.cpp (line 502)

[Differential] [Updated, 32 lines] D3355: add maskArea in panel view

mvourlakos updated this revision to Diff 8136. mvourlakos added a comment. - add setMask in showEvent REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3355?vs=8126&id=8136 BRANCH mask2 REVISION DETAIL https://phabricator.kde.org/D33

[Differential] [Commented On] D3355: add maskArea in panel view

mvourlakos added a comment. > So if you call setMask, before you call show() this will fail. > > I'm not sure what order that startup happens, and whether this will break if you have an autohide panel. > > You might need to copy the line > QWindow::setMask into PanelView::showEve

[Differential] [Closed] D3356: [Windowed Widgets Runner] Don't access invalid KPluginMetaData

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE59b2d1effcee: [Windowed Widgets Runner] Don't access invalid KPluginMetaData (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik added a comment. > What is the status of this? Dunno, somewhat lost motivation, frankly. Imho we **need** Meta+number, as that's what virtually any other desktop has and what anybody keeps complaining about. While Meta+some-other-shortcut and then pressing 1 would work for

Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/ --- Review request for Plasma and Fabian Vogt. Repository: plasma-framework

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100836 --- Ship it! Ship It! - David Edmundson On Nov. 14, 2016,

[Differential] [Commented On] D3357: Don't register a new service for screenshots

graesslin added a comment. While not perfect I do consider this as a dangerous change. It's kind of our public API. According to lxr.kde.org it's not used in our code, so from that side not a problem. My suggestion would be to hold the change a little bit. We need to change the DBus API

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

graesslin added a comment. My suggestion would be to make meta+number only work for the first task manager on the primary screen. Similar to how we do it with the meta only activation. It only triggers for the first launcher it finds. Yes, it would not support the full flexibility, but we al

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

hein added a comment. As maintainer: I agree with graesslin. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: cfeck,

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100841 --- Ship it! Tested, works fine! - Fabian Vogt On Nov. 14,

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100843 --- Ship it! Ship It! - Marco Martin On Nov. 14, 2016, 4:2

[Differential] [Accepted] D3357: Don't register a new service for screenshots

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. On second thought: we can push it directly REPOSITORY rKWIN KWin BRANCH scaling_2 REVISION DETAIL https://phabricator.kde.org/D3357 EMAI

[Differential] [Closed] D3338: [effects] Save zoom settings using kcfg generated class

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2b93939a67d9: [effects] Save zoom settings using kcfg generated class (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3338?vs=8087&id=8143 RE

[Differential] [Closed] D3339: [effects] Drop loading shadow config from MagicLamp

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa8fa1626eb9d: [effects] Drop loading shadow config from MagicLamp (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3339?vs=8088&id=8144 REVISI

[Differential] [Closed] D3340: [effects] Clean up saving of DesktopGrid config

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN75ab998de8df: [effects] Clean up saving of DesktopGrid config (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3340?vs=8089&id=8145 REVISION D

[Differential] [Closed] D3327: VirtualDesktopGrid operates on VirtualDesktop objects

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc0b2e5dc8bad: VirtualDesktopGrid operates on VirtualDesktop objects (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3327?vs=8065&id=8146 REVI

[Differential] [Request, 37 lines] D3361: Support multiple event types in X11EventFilter

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far the X11EventFilter only supported one event type. But most usecases for an X11EventFilte

[Differential] [Updated, 38 lines] D3361: Support multiple event types in X11EventFilter

graesslin updated this revision to Diff 8148. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - rebased on master - fix a bug in new code (didn't register on Workspace) REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Request, 54 lines] D3362: Port KillWindow to X11EventFilter

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Removes the special handling from events.cpp for KillWindow. The same functionality can be prov