Review Request 124093: Moving the opacity change from a ScriptAction to a parallel OpacityAnimator. That seems to cause a repaint in whatever weird environment happens to be the root of this bug.

2015-06-14 Thread Billy Lieurance
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-14 Thread Billy Lieurance
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/ --- (Updated June 14, 2015, 9:15 a.m.) Review request for Plasma. Summary (

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/#review81459 --- Wouldn't that cause strange visual effects for the slideshow,

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-14 Thread William Lieurance
> On June 14, 2015, 9:18 a.m., Kai Uwe Broulik wrote: > > Wouldn't that cause strange visual effects for the slideshow, when both > > images fade at the same time? > > > > Did you try setting visible to false rather than opacity to zero? Really > > strange bug, we set opacity to zero and unset

Re: Review Request 124062: Verify service has valid plugin info before using it

2015-06-14 Thread David Edmundson
> On June 10, 2015, 4:43 p.m., Aleix Pol Gonzalez wrote: > > Would a warning there make sense? It's odd when things don't work without > > notice. Done. Thanks. - David --- This is an automatically generated e-mail. To reply, visit: ht

Re: Review Request 124062: Verify service has valid plugin info before using it

2015-06-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124062/ --- (Updated June 14, 2015, 5:17 p.m.) Status -- This change has been ma

Re: testing the single QQmlEngine plasmashell

2015-06-14 Thread Marco Martin
On Sat, Jun 13, 2015 at 10:36 PM, Bhushan Shah wrote: > On Sun, Jun 14, 2015 at 7:53 AM, Marco Martin wrote: >> see if in kdeclarative.cpp line 98 it's going in the branch >> if (qmlObj) { and the qmlObj is correctly instantiated? > > default PlasmaQuick::AppletQuickItemPrivate::AppletQuickItemPr

Re: testing the single QQmlEngine plasmashell

2015-06-14 Thread Marco Martin
On Sat, Jun 13, 2015 at 10:36 PM, Bhushan Shah wrote: > default PlasmaQuick::AppletQuickItemPrivate::AppletQuickItemPrivate: > Falling back to legacy separed QQmlEngine for applet > "org.kde.plasma.notifications" > default KDeclarative::KDeclarative::setupBindings: Goes here! > > So it works just

Re: testing the single QQmlEngine plasmashell

2015-06-14 Thread Kai Uwe Broulik
> try now with up to date kdecarative Forgot to push? :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: testing the single QQmlEngine plasmashell

2015-06-14 Thread Marco Martin
On Sun, Jun 14, 2015 at 3:29 PM, Kai Uwe Broulik wrote: >> try now with up to date kdecarative > > Forgot to push? :) pushed now the beach was calling :p -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/

Re: testing the single QQmlEngine plasmashell

2015-06-14 Thread Bhushan Shah
On Mon, Jun 15, 2015 at 5:57 AM, Marco Martin wrote: > the beach was calling :p with x-test language seems to work now.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://m

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-14 Thread William Lieurance
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/ --- (Updated June 15, 2015, 5:47 a.m.) Review request for Plasma. Changes -