D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > Oh, OK, now I remember, sorry for misinforming you... > > I haven't had any problems with this, it "Just Worked" :) Maybe it should > return just plain QObject*, I'm not experienced in this area, what do you

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Thanks for your reply. Okay, so seems you did not hit anything related. > > Thing is, you added > `` > Q_INVOKABLE Plasma::Service *serviceForSource(const QString &so

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > I don't know, this code was there before my changes, I've just done some > refactoring here. Thanks for your reply. Okay, so seems you did not hit anything related. Thing is, you added `` Q_INVOKABLE Plasma:

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Hi. Seeing this code, I have a question: from what I understood so far, for > this method to be useable from the JavaScript inside QML, the type > "Plasma::Service *

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > systemtray.h:100 > */ > -Q_INVOKABLE void reorderItemAfter(QQuickItem* after, QQuickItem* before); > - > -Q_INVOKABLE bool isSystemTrayApplet(const QString &appletId); > +Q_INVOKABLE Plasma::Service *serviceForSource(const QStrin

D29703: Disable horizontal scrollbar in systemtray settings

.org/D29703 AFFECTED FILES applets/digital-clock/package/contents/ui/configTimeZones.qml applets/systemtray/package/contents/ui/ConfigEntries.qml wallpapers/image/imagepackage/contents/ui/config.qml To: davidre Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, za

D29703: Disable horizontal scrollbar in systemtray settings

(branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D29703 AFFECTED FILES applets/systemtray/package/contents/ui/ConfigEntries.qml To: davidre Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

This revision was automatically updated to reflect the committed changes. Closed by commit R120:00e64bdb3fa9: [applets/systemtray] Show base icon when AttentionIcon not set (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29544

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka added a comment. Can we have it reviewed before 5.19 release? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29544 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka added a comment. Firstly, AttentionIcon support was introduced in D24865 . It had a bug, fixed for 5.18 in D29386 . When I merged branch 5.18 (with D29386 ) into master, by mi

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

- Set NeedsAttention as a status and with no Attention Icon - Base Icon should render correctly REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D29544 AFFECTED FILES applets/systemtray/systemtraymodel.cpp To: kmaterka, #plasma_workspaces, #p

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b34e88da7a5d: [applets/systemtray] Hide/show expander arrow - regression fix (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28180

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

lets/systemtray/package/contents/ui/ExpanderArrow.qml applets/systemtray/package/contents/ui/HiddenItemsView.qml To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Zre

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. Ah, right, we just use the sort filter model, no model from C++. Meh, so I can't think of a better way right now either.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham, brou

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. I would suggest we add a `count` property with a `NOTIFY` signal on the model which is then updated on C++ side? I find that cleaner than doing that from QML like this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmate

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. #plasma ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#663325 , @ngraham wrote: > Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the merge conflicts. Merged. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.k

D29386: [systemtray] Fix SNI icon not rendering

ngraham added a comment. Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the merge conflicts. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-

D29386: [systemtray] Fix SNI icon not rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R120:77975468dc10: [systemtray] Fix SNI icon not rendering (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29386?vs=81903&id=8

D29386: [systemtray] Fix SNI icon not rendering

ANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D29386 AFFECTED FILES applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml applets/systemtray/systemtray.cpp applets/systemtray/systemtray.h dataengines/statusnotifieritem/statusnotifieritemsource.cpp To: kmat

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#662960 , @ngraham wrote: > Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks

D29386: [systemtray] Fix SNI icon not rendering

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks like

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. Separate Bug 420993 created for Media Player icon not rendering correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham, brou

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

This revision was automatically updated to reflect the committed changes. Closed by commit R120:026a29174279: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

CTED FILES applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray/systemtraymodel.cpp To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalo

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. In D29344#662586 , @ngraham wrote: > 5.19 hasn't branched yet, so code landed in master will still make it there. Maybe there was code freeze for frameworks? Or 5.18.5? Never mind :) > With this patch, I stil

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

ngraham added a comment. 5.19 hasn't branched yet, so code landed in master will still make it there. With this patch, I still see Media Player itself with a blank icon after opening Gwenview. Is that expected? F8282515: Screenshot_20200503_215149.png

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. This patch is for "Plasma/5.18" branch only. Can we have it merged before 5.18.5? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-devel,

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

This revision was automatically updated to reflect the committed changes. Closed by commit R120:efe4b603e92f: [applets/systemtray] Fix value read in some onXyxChanged connections (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D29386: [systemtray] Fix SNI icon not rendering

not rendered. It happens randomly, only some users are affected. It does not happen on every login. Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps. In QML all roles need to be defined before model is used. When data engines is

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

kmaterka added a comment. Fix exctracted from D29344 , to make things clear - one commit, one change. INLINE COMMENTS > main.qml:81 > target: plasmoid > -function onUserConfiguringChanged(userConfiguring) { > -if (userConfiguri

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

connection to use value directly from the sender. TEST PLAN Disable or enable plasmoid in System Tray setting - it should work correctly. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D29356 AFFECTED FILES applets/systemtray/package/contents/ui

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

.org/D29344 AFFECTED FILES applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray/systemtraymodel.cpp To: kmaterka, #plasma_workspaces, #plasma, ngraham Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Zre

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added inline comments. INLINE COMMENTS > apol wrote in main.qml:92 > Why's this needed? This is needed to fix different bug. I will create a separate patch for this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspac

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

apol added inline comments. INLINE COMMENTS > main.qml:92 > +function onExtraItemsChanged() { > +plasmoid.nativeInterface.allowedPlasmoids = > plasmoid.configuration.extraItems > } Why's this needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://pha

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. This fix should go with Plasma 5.19, if it is not too late (code freeze). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29344: [applets/systemtray] Fix ivisible plasmoid icons when new plasmoid added

Gwenview when Media Player is not in use. All icons should render correctly. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D29344 AFFECTED FILES applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray/package/contents/ui

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28311?vs=78561&id=78563

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ConfigEntries.qml:226 > case "disabled": > if (extraIndex > -1) { >

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

display it as shown instead of disabled. BUG: 419197 REPOSITORY R120 Plasma Workspace BRANCH systrayhidden REVISION DETAIL https://phabricator.kde.org/D28311 AFFECTED FILES applets/systemtray/package/contents/ui/ConfigEntries.qml To: nicolasfella, #plasma Cc: plasma-devel, Orage

D28259: [applets/systemtray] Default value for ItemLoader.source

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28259?vs

D28259: [applets/systemtray] Default value for ItemLoader.source

, error is printed in logs. TEST PLAN No warning about undefined value for url REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28259 AFFECTED FILES applets/systemtray/package/contents/ui/items/ItemLoader.qml To: kmaterka, #plasma_workspaces

D28109: [applets/systemtray] Simplify icon size logic

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a9d941b38e05: [applets/systemtray] Simplify icon size logic (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=78185&id=7

D28211: [applets/systemtray] Make Pin button a bit larger

/D28211?vs=78267&id=78300 BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D28211 AFFECTED FILES applets/digital-clock/package/contents/ui/CalendarView.qml applets/systemtray/package/contents/ui/ExpandedRepresentation.qml To: ngraham,

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. icon comes from plasma theme, which is F8195182: image.png it needs padding REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb, mart Cc: mart, ndavis, b

D28211: [applets/systemtray] Make Pin button a bit larger

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. wait, if you mean that you want the pin button with 22x22px icon size, this patch is not correct and it should have no size parameters REPOSITORY R120 Plasma Workspace REVISION DET

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. if the size of that button changes in systray, it muct change in calndar too REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb Cc: mart, nda

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a subscriber: mart. ngraham added a comment. The PC3 ToolButton has been "fixed" half a dozen times already and I imagine poor @mart is thoroughly sick of it by now... REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28211: [applets/systemtray] Make Pin button a bit larger

ndavis added a comment. In D28211#632893 , @ngraham wrote: > The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png > > However yeah, the actual icon size in a Tool

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a comment. The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png However yeah, the actual icon size in a ToolButton is `smallMedium`, so I guess the fact that you need to use `small` to get the r

D28211: [applets/systemtray] Make Pin button a bit larger

broulik added a comment. F8194458: Screenshot_20200323_102203.png Gets pretty large here, surely bigger than `small` icon size. Maybe another PlasmaComponents 3 issue? REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from

D28211: [applets/systemtray] Make Pin button a bit larger

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 for using standard size instead of using an hardcoded size. REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabrica

D28211: [applets/systemtray] Make Pin button a bit larger

FECTED FILES applets/systemtray/package/contents/ui/ExpandedRepresentation.qml To: ngraham, #vdg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added a comment. In D28180#632058 , @ngraham wrote: > This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to commen

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to comment. Oh and thanks for the code comments. Always very helpful! REPOSITORY R120 P

D28109: [applets/systemtray] Simplify icon size logic

lets/systemtray/package/contents/ui/ExpanderArrow.qml applets/systemtray/package/contents/ui/HiddenItemsView.qml applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/items/PlasmoidItem.qml applets/systemtray/package/contents/ui/i

D28109: [applets/systemtray] Simplify icon size logic

lets/systemtray/package/contents/ui/ExpanderArrow.qml applets/systemtray/package/contents/ui/HiddenItemsView.qml applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/items/PlasmoidItem.qml applets/systemtray/package/contents/ui/i

D28185: [applet/systemtray] Use model binding instead of copy

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17153c4ae204: [applet/systemtray] Use model binding instead of copy (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78181

D28185: [applet/systemtray] Use model binding instead of copy

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > broulik wrote in AbstractItem.qml:36 > You can simplify this to > > model.status || PlasmaCore.Types.UnknownStatus Done REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D28185: [applet/systemtray] Use model binding instead of copy

ILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray/package/contents/ui/items/PlasmoidItem.qml applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml To: kmaterka, #plasma_workspaces, #pl

D28185: [applet/systemtray] Use model binding instead of copy

apol added a comment. I like it better now, +1. Please address Kai's comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28185 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol Cc: apol, plasma-devel, Orage, LeGast00n, T

D28185: [applet/systemtray] Use model binding instead of copy

broulik added inline comments. INLINE COMMENTS > AbstractItem.qml:36 > property Item iconItem > -property int /*PlasmaCore.Types.ItemStatus*/ status > -property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus > +property int /*PlasmaCore.Types.ItemStatus*/ status: model.statu

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka added a comment. In D28185#631972 , @apol wrote: > I'm not convinced this is all that better. Without this `effectiveStatus` never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a diffe

D28185: [applet/systemtray] Us model binding instead of copy

CTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray/package/contents/ui/items/PlasmoidItem.qml applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml To: kmaterka, #plasma_worksp

D28185: [applet/systemtray] Us model binding instead of copy

apol added a comment. I'm not convinced this is all that better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28185 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D28185: [applet/systemtray] Us model binding instead of copy

PLAN No visible impact REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/items/ItemLoader.qml applets/systemtray

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.itemCount > 0 > ideally `root.hiddenLayout.count` should be used, but `count` is not u

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

sma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28180 AFFECTED FILES applets/systemtray/package/contents/ui/ExpanderArrow.qml applets/systemtray/package/contents/ui/HiddenItemsView.qml To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plas

D28109: [applets/systemtray] Simplify icon size logic

ngraham added a comment. Depends on the view; most people don't seem to use Phab's homepage so much compared to the email notifications generated when you mention people like @broulik, @mart, or @davidedmundson ;) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https:

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added a comment. In D28109#629974 , @ngraham wrote: > This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions in

D28109: [applets/systemtray] Simplify icon size logic

ngraham accepted this revision. ngraham added subscribers: davidedmundson, mart. ngraham added a comment. This revision is now accepted and ready to land. This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup vi

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.count > 0 > This fixes issue (regression) with expander arrow not hiding when all item

D28109: [applets/systemtray] Simplify icon size logic

. This gives additional benefits, like icons perfectly centered. TEST PLAN - Highlights should always be centered REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28109 AFFECTED FILES applets/systemtray/package/contents/ui/ExpanderArrow.qml

D28089: [applets/systemtray] Fix expanded representation's internal margins

This revision was automatically updated to reflect the committed changes. Closed by commit R120:695fec4a2d41: [applets/systemtray] Fix expanded representation's internal margins (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D28089: [applets/systemtray] Fix expanded representation's internal margins

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM both visually and codewise. REPOSITORY R120 Plasma Workspace BRANCH fix-popup-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D28089 To: ngraham, #vd

D28089: [applets/systemtray] Fix expanded representation's internal margins

RY R120 Plasma Workspace BRANCH fix-popup-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D28089 AFFECTED FILES applets/systemtray/package/contents/ui/ExpandedRepresentation.qml To: ngraham, #vdg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Fere

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. In D27958#627658 , @ngraham wrote: > After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened: > > F8176616: vokos

D27958: [SystemTray] Fix item size for very narrow panel

ngraham added a comment. After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened: F8176616: vokoscreenNG-2020-03-14_23-35-16.webm Could you i

D26923: Fix systemtray configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ce69fc4ea914: Fix systemtray configuration (authored by carewolf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26923?vs=74379&id=77568 REVISION DE

D27958: [SystemTray] Fix item size for very narrow panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:85f646eb5649: [SystemTray] Fix item size for very narrow panel (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27958?vs=77321&am

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. In D27958#625431 , @broulik wrote: > Not sure if it is just me but the vertical alignment looks slightly off > F8169131: Screenshot_20200310_172654.PNG > Or maybe that's the r

D27958: [SystemTray] Fix item size for very narrow panel

ngraham added a comment. Nice, drag-and-drop now correctly shows the menu for the case of dragging an icon from Kickoff or the task manager. However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more co

D27958: [SystemTray] Fix item size for very narrow panel

broulik added a comment. Not sure if it is just me but the vertical alignment looks slightly off F8169131: Screenshot_20200310_172654.PNG Or maybe that's the random different sizes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size): - SNI icons are rounded to nearest icon

D27958: [SystemTray] Fix item size for very narrow panel

check to not exceed poanel size. TEST PLAN - Make panel very narrow - icons should fit into panel - Repeat for vertical/horizontal REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27958 AFFECTED FILES applets/systemtray/package/contents/ui

D26992: [SystemTray] Use unified data model everywhere

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:39975673cb6a: [SystemTray] Use unified data model everywhere (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractItem.qml:34 > Lets look at fixing in a follow up patch > > QML can do enums now OK, I will change that in a separate patch REPOSITORY R120 Plasma Workspace BRANCH m

D26992: [SystemTray] Use unified data model everywhere

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > AbstractItem.qml:34 > property Item iconItem > property int /*PlasmaCore.Types.ItemStatus*/ status > +property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus Lets look at fixing in a

D27870: [applets/systemtray] Right align popup heading when in RTL mode

gvgeo added a comment. It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left. Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch. REPOSITORY R1

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. I doubt it. left-alignment is already the effective default anyway, so I'm actually surprised that explicitly setting it here makes RTL work. This hints at a deeper bug somewhere, unfortunately. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricato

D27870: [applets/systemtray] Right align popup heading when in RTL mode

filipf added a comment. In D27870#622843 , @ngraham wrote: > Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? Sounds like a better solution. I'm not sure if it would interfere wit

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27870 To: filipf, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27870: [applets/systemtray] Right align popup heading when in RTL mode

applets/systemtray/package/contents/ui/ExpandedRepresentation.qml To: filipf Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. UI and interaction are good, and a basic code review reveals no issues to me. Still, you may want to wait for a more thorough code review from a #plasma

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. Fixed better in D27628 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jrale

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. No, it's still broken for me even with that commit. :( F8128762: photo_2020-02-24_07-26-43.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc: mart, d

D27260: [applets/systemtray] Set pin button's size correctly

mart closed this revision. mart added a comment. this has been superseeded by R242:ba0b637de94a REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis C

D26992: [SystemTray] Use unified data model everywhere

ngraham added a comment. My bad, your patch actually fixes a pre-existing visual bug. :) That accounts for the change. +1 visually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, brou

D27570: [applets/systemtray] Clip ListView in config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:193c89a4a0cf: [applets/systemtray] Clip ListView in config (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27570?vs=76165&id=76180#toc REPOSITORY R120 Pl

D27570: [applets/systemtray] Clip ListView in config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R120 Plasma Workspace BRANCH clip REVISION DETAIL https://phabricator.kde.org/D27570 To: nicolasfella, #plasma, ngraham Cc: ngraham, plasma-devel, Orage,

  1   2   3   4   5   6   >