Re: network dataengine in kdereview

2008-08-25 Thread Kevin Ottens
Le Monday 25 August 2008, Aaron J. Seigo a écrit : > On Monday 25 August 2008, Gerhard Gappmeier wrote: > > Hi Aaron, > > > > I just took a quick look at the code. > > > > If noticed that readNumberFromFile() and readStringFromFile() are using > > fopen to access the file. > > the only place that t

Re: network dataengine in kdereview

2008-08-25 Thread Aaron J. Seigo
On Monday 25 August 2008, Gerhard Gappmeier wrote: > Hi Aaron, > > I just took a quick look at the code. > > If noticed that readNumberFromFile() and readStringFromFile() are using > fopen to access the file. the only place that those are used is actually commented out right now; they are used fo

Re: network dataengine in kdereview

2008-08-25 Thread Alex Merry
On Monday 25 August 2008 08:14:19 Gerhard Gappmeier wrote: > If noticed that readNumberFromFile() and readStringFromFile() are using > fopen to access the file. > 1.) For passing the filename as character string, it uses > QString::toLatin1() > This will not work if the filename has any special cha

Re: network dataengine in kdereview

2008-08-25 Thread Gerhard Gappmeier
Hi Aaron, I just took a quick look at the code. If noticed that readNumberFromFile() and readStringFromFile() are using fopen to access the file. 1.) For passing the filename as character string, it uses QString::toLatin1() This will not work if the filename has any special characters that don't

network dataengine in kdereview

2008-08-24 Thread Aaron J. Seigo
hi... i just finished porting the network DataEngine that was in playground to the current Solid APIs. everything seems to work and i'd like to see this functionality in 4.2, so i've moved it to kdereview into plasma/dataengines/network/. please review, comment, etc. -- Aaron J. Seigo humru