On 10/05/12 12:13, Alex Merry wrote:
> Thanks. I've applied all your suggestions to the scratch repo. I'll
> probably commit to kde-workspace and kdeplasma-addons tomorrow morning,
> I imagine (or whenever I'm next on my home computer).
Done.
___
Plas
On 10/05/12 11:51, David Edmundson wrote:
Only thing that was important was:
void MultiplexedService::activePlayerChanged(PlayerContainer *container)
{
-delete m_control.data();
+m_control.data()->deleteLater()
Other considerations:
[snip]
Thanks. I've applied all your suggestions t
On Thu, May 10, 2012 at 11:09 AM, Alex Merry wrote:
> On 05/05/12 19:00, David Edmundson wrote:
>>
>> Has anyone reviewed the Mpris-dataengine? If not I'll do that this
>> evening.
>
>
> Are you still intending to do this? I was originally planning to commit the
> dataengine and applet tomorrow,
On 05/05/12 19:00, David Edmundson wrote:
Has anyone reviewed the Mpris-dataengine? If not I'll do that this evening.
Are you still intending to do this? I was originally planning to commit
the dataengine and applet tomorrow, and it certainly needs to be done by
next Thursday (hard feature f
On 05/05/12 19:00, David Edmundson wrote:
> Has anyone reviewed the Mpris-dataengine? If not I'll do that this evening.
Eike Hein's done some testing of it, but hasn't actually reveiwed the
code (and I'm not sure how much he follows plasma development anyway).
On Sat, May 5, 2012 at 2:29 PM, Alex Merry wrote:
> On 03/05/12 22:18, David Edmundson wrote:
>> Now Playing QML Review:
>> all code should be in -> contents/ui, not at the top level dir.
>
> Done
>
>> Do you really want it set to keep-aspect ratio? It's not a great
>> default aspect ratio
On 03/05/12 22:18, David Edmundson wrote:
> Now Playing QML Review:
> all code should be in -> contents/ui, not at the top level dir.
Done
> Do you really want it set to keep-aspect ratio? It's not a great
> default aspect ratio anyway.
Ah, I'd forgotten that it's necessary to explicitly
On Mon, Apr 30, 2012 at 2:24 PM, Alex Merry wrote:
> On 27/04/12 23:52, Alex Merry wrote:
>>
>> This is following up my previous email about the mpris2 engine, and
>> asking for a formal review.
>>
>> I've lost track of how the review procedure has changed since the move
>> to git, and I can't fin
On 27/04/12 23:52, Alex Merry wrote:
This is following up my previous email about the mpris2 engine, and
asking for a formal review.
I've lost track of how the review procedure has changed since the move
to git, and I can't find documentation of it anywhere, so I apologise if
I screw this up.
On 29/04/12 13:46, David Edmundson wrote:
Could you make sure to update this wiki page on QML porting progress:
http://community.kde.org/Plasma/PlasmoidScripting#Porting_Plasmoids_to_QML
Don't want anyone duplicating your work by mistake.
Done. Thanks for the heads up.
Could you make sure to update this wiki page on QML porting progress:
http://community.kde.org/Plasma/PlasmoidScripting#Porting_Plasmoids_to_QML
Don't want anyone duplicating your work by mistake.
Dave
___
Plasma-devel mailing list
Plasma-devel@kde.org
h
On 27/04/12 23:52, Alex Merry wrote:
> I've rewritten the nowplaying applet in QML (with many improvements,
> such as looking nice and behaving well in vertical and horizontal form
> factors), and that should replace the existing nowplaying applet (of
> which I am the maintainer) in kdeplasma-addon
This is following up my previous email about the mpris2 engine, and
asking for a formal review.
I've lost track of how the review procedure has changed since the move
to git, and I can't find documentation of it anywhere, so I apologise if
I screw this up.
The mpris2 engine, which I think should
13 matches
Mail list logo
