Re: KRunner and KActivities

Heyho, as stated in #Plasma, I will take care of it shortly ;) Regards Alex On 11/20/23 18:57, Jonathan Riddell wrote: I've just seen that KRunner uses KActivities but we moved activities to Plasma and Runner is in Frameworks.  Whatever shall we do? Joanthan

KRunner and KActivities

I've just seen that KRunner uses KActivities but we moved activities to Plasma and Runner is in Frameworks. Whatever shall we do? Joanthan

Re: Move krunner also to plasma bundle?

KWin overview effect. Regarding Friedrichs points: In KF5, KRunner has had a large dependency tree, including plasma-frameworks in its public header. The model has been moved from Milou to KRunner in KF6. This makes KRunner more useful (without having to implement a model oneself) for consumers. Due

Re: Move krunner also to plasma bundle?

On 11/5/23 10:12, Nate Graham wrote:> +1, it's an integral part of Plasma and I would support moving it there. And Milou is already there. For that matter, I'd also support moving both Milou and what's currently in the KRunner framework just into plasma-workspace for simpl

Re: Move krunner also to plasma bundle?

On 11/5/23 07:43, Friedrich W. H. Kossebau wrote: While at it: would KRunner not also be a good candidate to bundle with Plasma instead of KF? (to repeat some old record :P) AFAIK the only programs hosting KRunner plugins are Plasma ones, everyone else just provides plugins. So similar to

Move krunner also to plasma bundle? (was: Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now)

ions link to kactivities, too. > I think it just makes it more clear that this will just work with > Plasma. > > But I can live with the status quo, too, just thought it would be > cleaner. While at it: would KRunner not also be a good candidate to bundle with Plasma instead of KF

Re: Loading RunCommand.qml file in KRunner using QRC

proposed change of https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032. Currently we load the main KRunner QML file “RunCommand.qml” from the look and feel KPackage. However, this has caused issues repeatedly in the past, because old/broken QML files can be loaded. The idea from

Loading RunCommand.qml file in KRunner using QRC

Hello everyone,   I write this mail regarding the proposed change of https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032. Currently we load the main KRunner QML file “RunCommand.qml” from the look and feel KPackage. However, this has caused issues repeatedly in the past, because

Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

depend on it > (just one dependency in KRunner, but it is deprecated, to be removed at > branching time). Maybe frameworksintegration? (to be checked) It seems these days the only real user of plasma-frameworks & krunner libraries is the Plasma shell itself, with other applicatio

Re: Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

On sabato 17 aprile 2021 16:38:32 CEST Friedrich W. H. Kossebau wrote: > It seems these days the only real user of plasma-frameworks & krunner > libraries is the Plasma shell itself, with other applications only providing > plugins/extensions and only targeting Plasma again. IIRC A

Fwd: Krunner plugins - basic questions from the new plasma dev

Forwarding to plasma-devel -- Weitergeleitete Nachricht -- Betreff: Krunner plugins - basic questions from the new plasma dev Datum: Sonntag, 18. April 2021, 21:07:37 CEST Von: Slawek Kaplonski An: kde-de...@kde.org Hi, I'm user of the KDE since some time and now I wa

Re: Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

> It seems these days the only real user of plasma-frameworks & krunner > libraries is the Plasma shell itself, with other applications only providing > plugins/extensions and only targeting Plasma again. That is mostly in line with other discussions in plasma. There is a ticket spl

D21341: Call KRunner KRunner

mart added a comment. This was a terrible decision. KRunner is the worst jargon one can imagine and shouldn't be anywhere in user facing UI REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21341 To: ngraham, #vdg, #plasma, ndavis Cc: mart, abetts, n

D26718: aggregate text for KRunner in DesktopView

meven closed this revision. meven added a comment. At moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, br

D26718: aggregate text for KRunner in DesktopView

pdabrowski added a comment. Moved to GitLab: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: pzro, pl

D29401: [KRunner] Fix watched config file path

ksmanis closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma, ngraham Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliez

D29411: [KRunner] Watch config with KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29411?vs=81896&id=81904#toc REPOSITORY R120 Plasma Works

D29411: [KRunner] Watch config with KConfigWatcher

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, much nicer! Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29411 To: broulik, #plasma, ngraham, ksmanis Cc: plasma-devel, Orage, LeGast00

D29411: [KRunner] Watch config with KConfigWatcher

5.18 please - Cleared history in KCM with D29410 <https://phabricator.kde.org/D29410>, confi was reloaded and history gone right away REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29411 AFFECTED FILES krunner/view.cpp krunner/view.h To: broulik, #

D29401: [KRunner] Fix watched config file path

ngraham added a comment. Maybe we can do that on master and land this on the stable branch? REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma, ngraham Cc: ngraham

D29401: [KRunner] Fix watched config file path

broulik added a comment. Ideally, we'd change the KCM to write the key with `KConfig::Notify` and then use `KConfigWatcher` here REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D2940

D29401: [KRunner] Fix watched config file path

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch! Seems worthy of landing on the stable branch? What do you think, @broulik? REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master

D29401: [KRunner] Fix watched config file path

ksmanis added a comment. Nope, different bugs, similar solutions. I can still reproduce the other bug (I never noticed it before btw). I am not sure if this patch fixes any other regressions other than the Clear History button in the KCM. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29401: [KRunner] Fix watched config file path

broulik added a comment. That's not the bug I tried to solve in D26444 , was it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29401: [KRunner] Fix watched config file path

ma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D29401 AFFECTED FILES krunner/view.cpp To: ksmanis, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBo

D28853: krunner: Prevent regression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by apol, committed by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28853?vs=80192&id=8

D28853: krunner: Prevent regression

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Proper fix with refactoring will take too long, let's take this for now. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28853 To: apol, #p

D28853: krunner: Prevent regression

apol created this revision. apol added a reviewer: Plasma. apol added a project: Plasma. apol requested review of this revision. REVISION SUMMARY It was pointed out to me that using NoDisplay=true breaks starting krunner. Alternatively D24956 <https://phabricator.kde.org/D24956> co

D28783: krunner: polish placement

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c963fe873f7c: krunner: polish placement (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28783?vs=80036&id=80091 REVISION DE

D28783: krunner: polish placement

L https://phabricator.kde.org/D28783 AFFECTED FILES krunner/CMakeLists.txt krunner/krunner.desktop.cmake krunner/view.cpp To: apol, #plasma, cblack Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28783: krunner: polish placement

apol added a subscriber: davidedmundson. apol added a comment. This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18 , so I'll wait for @davidedmundson's comment. REPOSITORY R120 Plasma Workspac

D28783: krunner: polish placement

ETAIL https://phabricator.kde.org/D28783 AFFECTED FILES krunner/CMakeLists.txt krunner/krunner.desktop.cmake krunner/view.cpp To: apol, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. > Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :) You can't move KRunner around, though, either, and the number of results shown is based on screen size and easily overflows the screen when it is f

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. This breaks KRunner's shadow against a top panel: F8219543: Screenshot_20200406_093346.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #plasma, apol Cc: pereira.

D28368: [krunner] Avoid (a third!) pointless config parse

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6dc04ef0adec: [krunner] Avoid a uneeded pointless config parse (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28368?vs=78711

D28366: [krunner] Don't set the position three times in a row

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2d372d3dfd1: [krunner] Don't set the position three times in a row (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D283

D28365: [krunner] Avoid (another) pointless config load on start

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1c48e351c646: [krunner] Avoid reparsing the config load on start (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28365?vs

D28364: [krunner] Avoid a config pointless extra config load

This revision was automatically updated to reflect the committed changes. Closed by commit R120:23534a3b4f6e: [krunner] Avoid a config pointless extra config load (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28364?vs

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #plasma, apol Cc: pereira.alex, ng

D28366: [krunner] Don't set the position three times in a row

pereira.alex added a comment. I don't want to be *that guy* but this is one of the things I do in every kde desktop I have. User facing configurable UI would be great ! That said, although I love the free floating version, I wouldn't run to xxx desktop if it was removed ! :) REPOSITORY

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. In D28366#636969 , @broulik wrote: > Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained ...That, or make it configurable with a

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #pla

D28368: [krunner] Avoid (a third!) pointless config parse

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Sounds like you can merge this with the other similar one, right? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28368 To: davidedmundson, #

D28365: [krunner] Avoid (another) pointless config load on start

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > view.cpp:110 > // Catch both, direct changes to the config file ... > -connect(KDirWatch::self(), &KDirWatch::dirty, this, &View::reloadConfig); > -connect(KDir

D28368: [krunner] Avoid (a third!) pointless config parse

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We are krunner, our default config will be krunnerrc, we can load the

D28366: [krunner] Don't set the position three times in a row

davidedmundson updated this revision to Diff 78708. davidedmundson retitled this revision from "[krunner] Don't set the position twice in a row" to "[krunner] Don't set the position three times in a row". davidedmundson edited the summary of this revision.

D28366: [krunner] Don't set the position twice in a row

BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 AFFECTED FILES krunner/view.cpp To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed

D28365: [krunner] Avoid (another) pointless config load on start

://phabricator.kde.org/D28365 AFFECTED FILES krunner/view.cpp krunner/view.h To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D28364: [krunner] Avoid a config pointless extra config load

DETAIL https://phabricator.kde.org/D28364 AFFECTED FILES krunner/view.cpp To: davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahi

D26718: aggregate text for KRunner in DesktopView

pzro added a comment. Hey guys, this is what I think 1. Having the shell capture input and forward it to KRunner when it comes up - because KRunner is too slow to come up and capture text on demand 2. Having KRunner in the background from the beginning - because KRunner is too slow on

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. @davidedmundson stable branch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. All right then. I guess it is a tricky problem. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26718: aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#622311 <https://phabricator.kde.org/D26718#622311>, @ngraham wrote: > Are you planning to work on that other part in this patch, or in a separate one? I do not plan to change this patch. As for solving the issue with KRunner inv

D26718: aggregate text for KRunner in DesktopView

blem of keystrokes getting eaten when activating KRunner using a global shortcut. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D26718: aggregate text for KRunner in DesktopView

davidedmundson added a comment. > Are you planning to work on that other part in this patch, or in a separate one? To do what exactly? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ng

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. Can confirm the fix when running from the desktop, but not when using the shortcut. So I wouldn't call 416145 fully fixed yet. Are you planning to work on that other part in this patch, or in a separate one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76799. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=76798&id=76799 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES shell/desktopview.cpp shell/desktopview.h To: pdabrowski,

D26718: aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:246 > > +bool DesktopView::handleKRunnerTextInput(QKeyEvent *e) { > +// allow only Shift and GroupSwitch modifiers TODO: code style: { REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D267

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76798. pdabrowski retitled this revision from "autostart KRunner with Plasma, aggregate text for KRunner in DesktopView" to "aggregate text for KRunner in DesktopView". pdabrowski edited the summary of this revision. pdabro

D27458: Set a better position for Krunner in wayland

trmdi closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27458 To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himc

D27458: Set a better position for Krunner in wayland

TAIL https://phabricator.kde.org/D27458 AFFECTED FILES krunner/view.cpp krunner/view.h shell/strutmanager.cpp shell/strutmanager.h To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, rag

D27458: Set a better position for Krunner in wayland

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Lets go for it. INLINE COMMENTS > view.cpp:411 > +{ > +m_realVisible = visible; > + this is a very confusing name. It refers to the visible state krunner

D27458: Set a better position for Krunner in wayland

.org/D27458 AFFECTED FILES krunner/view.cpp krunner/view.h shell/strutmanager.cpp shell/strutmanager.h To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himc

D27458: Set a better position for Krunner in wayland

ttps://phabricator.kde.org/D27458 AFFECTED FILES krunner/view.cpp krunner/view.h shell/strutmanager.cpp shell/strutmanager.h To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zre

D27458: Set a better position for Krunner in wayland

trmdi added a comment. In D27458#618437 , @davidedmundson wrote: > Idea is nice. > > > Does this not jitter on first load? Starting off in 0,0 then moving across? > We now have position async() but we're doing that after we've shown

D27458: Set a better position for Krunner in wayland

davidedmundson added a comment. >> Does this not jitter on first load? Starting off in 0,0 then moving across? >> We now have position async() but we're doing that after we've shown the window. > > I don't think so. The `show()` is in the callback. /A/ show() is there. It se

D27458: Set a better position for Krunner in wayland

meven added a comment. In D27458#618437 , @davidedmundson wrote: > Idea is nice. > > > Does this not jitter on first load? Starting off in 0,0 then moving across? > We now have position async() but we're doing that after we've shown

D27458: Set a better position for Krunner in wayland

davidedmundson added a comment. Idea is nice. Does this not jitter on first load? Starting off in 0,0 then moving across? We now have position async() but we're doing that after we've shown the window. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D27458: Set a better position for Krunner in wayland

meven added a comment. ping @davidedmundson REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27458 To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zr

D27458: Set a better position for Krunner in wayland

ILES krunner/view.cpp shell/strutmanager.cpp shell/strutmanager.h To: trmdi, #plasma, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuter

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 75879. trmdi added a comment. Use asyncCall REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75828&id=75879 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES kru

D27458: Set a better position for Krunner in wayland

apol added a comment. +1 on fixing this INLINE COMMENTS > view.cpp:240 > +QDBusInterface strutManager("org.kde.plasmashell", "/StrutManager", > "org.kde.PlasmaShell.StrutManager"); > +QDBusReply pr = strutManager.call("availableScreenRect", > shownOnScreen->name()); > +

D27458: Set a better position for Krunner in wayland

better value from plasmashell CCBUG: 386114 TEST PLAN Krunner isn't overlapped by a top panel in all cases REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27458 AFFECTED FILES krunner/view.cpp shell/strutmanager.cpp

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson added a comment. > So you oppose preloading of KRunner service, but accept it continuing to run forever awaiting its next use. I don't find this consistent. It's a common lazy-load pattern. Though that extension of closing down would also be a direction I w

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595756 <https://phabricator.kde.org/D26718#595756>, @davidedmundson wrote: > I don't want us to make krunner autostart. It's a hack, not a fix. I'm gonna play devil's advocate here :) If having an already runn

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski planned changes to this revision. pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:262 > if (!e->modifiers() || e->modifiers() == Qt::ShiftModifier) { > const QString text = e->text().trimmed(); > if (!text.isEmpty() && text[0].isPrint()) { TO

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The continual forwarding of keys makes sense. I'm happy to accept that. I don't want us to make krunner autostart. It's a hack, not a fix. RE

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 73740. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=73737&id=73740 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES krunner/CMakeLists.txt krunner/

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:231 > This is not how we want to autostart something :) Instead, you want to place > the desktop file in autostart folder again Right :) I thought of this so that everytime Plasma starts it ensures KRunner i

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595688 <https://phabricator.kde.org/D26718#595688>, @broulik wrote: > Maybe if we autostarted KRunner based on whether it was used previously "Used previously" as in opened at least once? I guess this is always true for

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

broulik added a comment. Hmm, I'd appreciate some startup time optimizations for KRunner first. Maybe if we autostarted KRunner based on whether it was used previously would be a nice trade-off between resources for systems that don't use it and power users that always use

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

ngraham added a comment. IIRC we used to do this, but changed it to run-on-demand to save some memory on startup. Might be worth revisiting that though, since I can confirm the latency that leads to the first few characters getting typed into the open app instead of KRunner, which is

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY autostart KRunner with Plasma as daemon to

D24033: Add Meta+Space as a default shortcut to activate KRunner

ngraham added a comment. Yes, I reverted it in 469a7c1e33f83d6b73610997811fb131b5af80ca , which was released with Plasma 5.17.5. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24033

D24033: Add Meta+Space as a default shortcut to activate KRunner

aalam added a comment. Hi @ngraham Have you got chance to revert it? As KDE multilingual user, I still not able to use ibus keyboard in KDE from last month even tried to reset keyboard shortcut. Help will be really appreciated. REPOSITORY R120 Plasma Workspace REVISION DETAI

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven planned changes to this revision. meven added a comment. In D26111#589209 , @ivan wrote: > > Why not change the recentdocuments runner? > > Will do REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.or

D26149: Change krunner calculator to display significant digits

ngraham added a comment. Thanks very much for the patch! May it be the first of many. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26149 To: lukjp, broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas

D26149: Change krunner calculator to display significant digits

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e374492d24f4: Change krunner calculator to display significant digits (authored by lukjp, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin configuration changes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26445

D26111: KRunner add a recentlyused runner accessing KActivityStats data

ivan added a comment. > Why not change the recentdocuments runner? Looks fine to me, I just don't see a response to this comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel,

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Anyone to review this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, n

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Connect `configCommitted` to ensure "Apply" gets enabled when you change any of the runner plugin

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven marked 3 inline comments as done. meven added a comment. In D26111#580344 , @meven wrote: > Two points raised by @broulik but not resolved : > > - should display a specific icon based on file mimetype ? > - should we allow to open a fo

D24033: Add Meta+Space as a default shortcut to activate KRunner

ngraham added a comment. By ibus, yeah. :/ I found that out last week. I'm probably going to end up reverting this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24033 To: ngraham, #vdg, #plasma, ndavis, GB_2 Cc: alzoubi, GB_2, romangg, ndavis, plasma-dev

D24033: Add Meta+Space as a default shortcut to activate KRunner

alzoubi added a comment. Meta+Space used for chang Keyboard Layout. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24033 To: ngraham, #vdg, #plasma, ndavis, GB_2 Cc: alzoubi, GB_2, romangg, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachu

D26149: Change krunner calculator to display significant digits

lukjp created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lukjp requested review of this revision. REVISION SUMMARY Change the qalculate krunner module to print only significant digits instead of an interval as this is sometimes unreadable. BUG

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven updated this revision to Diff 71865. meven added a comment. Better Name in json REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71858&id=71865 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26111 AFFECTED FILES CM

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Two points raised by @broulik but not resolved : - should display a specific icon based on file mimetype ? - should we allow to open a folder's parent folder through an action I am in favor of keeping those two behaviors, but I would welcome other constructiv

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven updated this revision to Diff 71858. meven marked 5 inline comments as done. meven added a comment. address review REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71857&id=71858 BRANCH master REVISION DETAIL https://phabricator.

D26111: KRunner add a recentlyused runner accessing KActivityStats data

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Why not change the recentdocuments runner? We have various places where we whitelist recentdocuments as a runner and if a user disabled it, this would not be carried over withou

  1   2   3   4   5   6   7   8   9   10   >