Re: Review Request 119053: KGlobalAccel fixes for loading shortcuts

2014-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119053/#review61346 --- This review has been submitted with commit 4caa63d655d603268d

Re: Review Request 119053: KGlobalAccel fixes for loading shortcuts

2014-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119053/ --- (Updated July 1, 2014, 8:37 a.m.) Status -- This change has been mar

Re: Review Request 119053: KGlobalAccel fixes for loading shortcuts

2014-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119053/#review61344 --- Ship it! Push it, after looking at my small optimization sugg

Review Request 119053: KGlobalAccel fixes for loading shortcuts

2014-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119053/ --- Review request for KDE Frameworks, Plasma and David Faure. Repository: kg

Meta key and Qt (Re: kglobalaccel fixes)

2014-03-16 Thread David Faure
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: > One thing is a bit puzzling, perhaps someone knows how to go about this: > The meta key behaves different now, when I edit a shortcut, it's accepted > as soon as I press the meta key, so it's not seen as a modifier, but as a > key of its

Re: kglobalaccel fixes

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: > A quick heads-up: I'm looking into what's broken in our global shortcuts. > Here's a quick run-down of my findings so far: > > kglobalaccel has some brokenness in it. It used to poke into the privates of > KGlobalShortcutInfo in order to

kglobalaccel fixes

2014-03-11 Thread Sebastian Kügler
A quick heads-up: I'm looking into what's broken in our global shortcuts. Here's a quick run-down of my findings so far: kglobalaccel has some brokenness in it. It used to poke into the privates of KGlobalShortcutInfo in order to create its own object in a cast. This code is disabled right now