Hi all,
I started working on Plasma digital-clock, to try and implement some
changes in layout. Since I'm a complete novice I'm reviewing the existing
code of the applet to understand it (I can understand C++/Qt, but don't
know KDE internals).
I am now looking at conf
eviewboard.kde.org/r/108422/ .
> It ensures the "configChanged" event is emitted when the user changes the
> configuration of a QML-based containment.
>
>
> Diffs
> -
>
> plasma/containment.cpp a454d04
>
> Diff: http://git.reviewboard.kde.org/r/108423/diff/
>
. 15, 2013, 12:04 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> ---
>
> This patch is the second half of https://git.reviewboard.kde.org/r/108422/ .
> It ensures the "configChanged" event is emitted when the user changes t
patch is the second half of https://git.reviewboard.kde.org/r/108422/ . It
ensures the "configChanged" event is emitted when the user changes the
configuration of a QML-based containment.
Diffs
-
plasma/containment.cpp a454d04
Diff: http://git.reviewboard.kde.org/r/108423/diff/
Connecting configChanged() explicitly was the cause of the problem
apparently (I need to test it a little bit more). In many forum I've
found that the people suggest to do this connection, maybe it's old
stuff.
Another strange thing I noticed is that when I click OK in the config
dial
On Sunday, February 5, 2012 15:16:03 Simone Gaiarin wrote:
> I call configChanged() once in the init function and then I connect it
> to the configChanged() signal.
you don't need to connect it to any signal. i'm not sure if that's the cause
of your problem, but it is u
I call configChanged() once in the init function and then I connect it
to the configChanged() signal.
Here you can find the code:
https://github.com/simgunz/redshift-plasmoid/blob/master/contents/code/main.py
2012/2/5 Aaron J. Seigo :
> On Sunday, February 5, 2012 11:44:02 Simone Gaiarin wr
On Sunday, February 5, 2012 11:44:02 Simone Gaiarin wrote:
> Hi,
> I wrote a python plasmoid that needs to restart a program (redshift)
> everytime that the configuration is changed by the user (the plasmoid
> configChanged() function reacts to the signal). When the program is
> res
Hi,
I wrote a python plasmoid that needs to restart a program (redshift)
everytime that the configuration is changed by the user (the plasmoid
configChanged() function reacts to the signal). When the program is
restarted the user is aware of it, because the screen color become
white and than red
On Tuesday, October 19, 2010, Ingomar Wesp wrote:
> While implementing configChanged() in the quicklaunch plasmoid, I noticed
> (and worked around) the following problem:
please do not work around bugs. it usually just causes new bugs later.
(and sometimes you end up actually working aroun
Höglund.
Changes
---
formatting++
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting) will take effec
Höglund.
Changes
---
More fixes for configChanged as pointed out by notmart
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by t
On Tue, Sep 14, 2010 at 10:22 PM, Anne-Marie Mahfouf wrote:
> On Tuesday 14 September 2010 01:55:39 Aaron J. Seigo wrote:
> > On Saturday, September 4, 2010, Aaron J. Seigo wrote:
> > > All applets we ship that have any configuration will implement
> > > configChan
Höglund.
Changes
---
More fixes for filters and MimeList
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting)
On Tuesday 14 September 2010 01:55:39 Aaron J. Seigo wrote:
> On Saturday, September 4, 2010, Aaron J. Seigo wrote:
> > All applets we ship that have any configuration will implement
> > configChanged()
>
> it looks like we've accomplished our goal! folderview still ha
Höglund.
Changes
---
After much poking around and thanks to notmart and aseigo, finally implemented
it :D
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"b
On Tuesday 14 September 2010 10:18:42 Marco Martin wrote:
> i think it's one of the very few ways to get this sort of small, long
> repetitive and boring things done ;)
+1.
It also works as an excellent way of team-building ;)
Cheers!
--
---
On Tuesday 14 September 2010, Aaron J. Seigo wrote:
>
> if so, i have a few more similarly "entry level, detail oriented" items
> that we could set as a new focus item.
i think it's one of the very few ways to get this sort of small, long
repetitive and boring things done ;)
Cheers,
Marco Mart
On Tue, Sep 14, 2010 at 12:55 AM, Aaron J. Seigo wrote:
> feedback time: was this a useful / helpful way to go about getting such
> improvements done? for those who got involved: was it enjoyable for you, and
> would you do it again?
It was definitely a nice way to get into hacking on plasma, and
On Saturday, September 4, 2010, Aaron J. Seigo wrote:
> All applets we ship that have any configuration will implement
> configChanged()
it looks like we've accomplished our goal! folderview still has some
outstanding items in it, but they are being actively worked on.
thank-you to e
On Sunday, September 12, 2010 18:38:04 Rohan Garg wrote:
> Sorry that im waayy behind the schedule on this one, since this is my first
> patch to plasma, it might take another 10 days to perfect it, ive already
> fixed most of the issues with my patch on reviewboard for folderview, just
> need to f
Hi
Sorry that im waayy behind the schedule on this one, since this is my first
patch to plasma, it might take another 10 days to perfect it, ive already
fixed most of the issues with my patch on reviewboard for folderview, just
need to fix the iconSizes issue.
Extremely sorry for the delay.
Regard
On Saturday 04 September 2010, Aaron J. Seigo wrote:
> hi all...
>
> as you can see here:
>
> http://community.kde.org/Plasma/Tasks#Plasmoids
>
checked/fixed all in netbook, desktop and mobile shells
Cheers,
Marco Martin
___
Plasma-devel mailing
2010-09-11 02:00:33)
>
>
> Review request for Plasma.
>
>
> Summary
> ---
>
> Add configChanged() to the Tasks plasmoid, and fix a few warnings.
>
>
> Diffs
> -
>
>
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/ab
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5313/
---
Review request for Plasma.
Summary
---
Add configChanged() to the
On Tue, Sep 7, 2010 at 8:11 AM, Aaron J. Seigo wrote:
> On Saturday, September 4, 2010, Aaron J. Seigo wrote:
>
>> hi all...
>
>>
>
>> as you can see here:
>
>>
>
>> http://community.kde.org/Plasma/Tasks#Plasmoids
>
> i went to finish off
On Saturday, September 4, 2010, Aaron J. Seigo wrote:
> hi all...
>
> as you can see here:
>
> http://community.kde.org/Plasma/Tasks#Plasmoids
i went to finish off my evening by implementing configChanged() in another
widget that needed it, and then went to this page to
hi all...
as you can see here:
http://community.kde.org/Plasma/Tasks#Plasmoids
we have a large number of plasmoids in kdeplasma-addons that do not have
configChanged() implementations, meaning they will not work nicely in
plasmoidviewer anymore and they will not work well with the
On Sunday 22 August 2010 19:44:36 Harald Sitter wrote:
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp (Diff
> revision 7) void FolderView::init()
> 444
> const QList iconSizes = QList() << 16 << 22 << 32 << 48 <<
> 64 << 128; This is duplicated with configAccepted!
>
>
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5049/
> ---
>
> (Updated 2010-08-22 17:07:53)
>
>
> Review request for Plasma and Fredrik Höglund.
>
>
> Summ
Höglund.
Changes
---
Final patch to fix all the stuff i could find.Seems to be working after testing
on my machine
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
Höglund.
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting) will take effect.
Diffs
-
/trunk/KDE/kdebase/a
Höglund.
Changes
---
Remove whitespaces
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting) will take effec
Höglund.
Changes
---
Fix Double declarations, dont even ask :P
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scrip
Höglund.
Changes
---
Define a few variables
Summary
---
Extend FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting) will take effec
FolderView::configChanged() such that all configuration options are read
there on FolderView start. This will ensure that configuration changes made
"behind its back" (e.g. by the Desktop Scripting) will take effect.
Diffs
-
/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.c
2010-08-16 14:31:05)
>
>
> Review request for Plasma and Fredrik Höglund.
>
>
> Summary
> ---
>
> Extend FolderView::configChanged() such that all configuration options are
> read there on FolderView start. This will ensure that configuration changes
Hello,
as some of you may have already noticed by the flood of commits, i just
finished implementing configChanged() for all the applets in kdebase. Please
report if you find any strange behiavour, totally possible. :-)
Now, I think I'm going to start with kdeplasma-addons. If somebody o
On Tue, Jan 19, 2010 at 8:46 AM, Aaron J. Seigo wrote:
> *sigh*
>
> so i realized with a start this evening that virtually none of our Plasmoids
> implement configChanged(). this means that the plasma-desktop js scripting is
> going to be nearly useless with most of them in terms
On January 19, 2010, Marco Martin wrote:
> On Tue, Jan 19, 2010 at 8:46 AM, Aaron J. Seigo wrote:
> > *sigh*
> >
> > so i realized with a start this evening that virtually none of our
> > Plasmoids implement configChanged(). this means that the plasma-desktop
>
On Tue, Jan 19, 2010 at 8:46 AM, Aaron J. Seigo wrote:
> *sigh*
>
> so i realized with a start this evening that virtually none of our Plasmoids
> implement configChanged(). this means that the plasma-desktop js scripting is
> going to be nearly useless with most of them in terms
On January 19, 2010, Thomas Olsen wrote:
> On Tuesday 19 January 2010 08:46:14 Aaron J. Seigo wrote:
> > *sigh*
> >
> > so i realized with a start this evening that virtually none of our
> >
> > Plasmoids implement configChanged(). this means that the plasma-d
On Tuesday 19 January 2010 08:46:14 Aaron J. Seigo wrote:
> *sigh*
>
> so i realized with a start this evening that virtually none of our
> Plasmoids implement configChanged(). this means that the plasma-desktop js
> scripting is going to be nearly useless with most of t
*sigh*
so i realized with a start this evening that virtually none of our Plasmoids
implement configChanged(). this means that the plasma-desktop js scripting is
going to be nearly useless with most of them in terms of setting the
configuration for them (without a plasma restart, of course
On Wednesday 27 May 2009 18:39:14 Richard Dale wrote:
> As well as your patch don't we need a 'do nothing' default
> implemtation of configChanged()?
Yes, that's true. Committed patch with this addition.
Petri
signature.asc
Description: This is a dig
nfigLoader == 0?
>>
>> this should be better in trunk now. testing with the javascript
>> Plasma::ScriptEngine i'm only getting configChanged calls when the config
>> actually changes now. huzzah for that.
>
> Works with python applet too. Is it ok to commmit configChang
r == 0?
> >
> > this should be better in trunk now. testing with the javascript
> > Plasma::ScriptEngine i'm only getting configChanged calls when the config
> > actually changes now. huzzah for that.
>
> Works with python applet too. Is it ok to commmit configChan
e javascript
> Plasma::ScriptEngine i'm only getting configChanged calls when the config
> actually changes now. huzzah for that.
Works with python applet too. Is it ok to commmit configChanged() patch to
pyappletscript.py?
Petri
signature.asc
Description: This is
On Tuesday 26 May 2009, Petri Damstén wrote:
> Yes, seems to be called only once now. I think it still gets called when
> Cancel is pressed if configLoader == 0?
this should be better in trunk now. testing with the javascript
Plasma::ScriptEngine i'm only getting configChanged cal
t; // manually call configChanged, otherwise let the loader do that for us
> q->configChanged();
> }
>
> does that fix it for you properly?
Yes, seems to be called only once now. I think it still gets called when
Cancel is pressed if configLoader == 0?
Petri
signature.asc
D
On Tuesday 26 May 2009, Petri Damstén wrote:
> plasmoidviewer with python applet start (configChanged called 4 times):
hm... too many calls to writeConfig are happening, and KConfigSkeleton is Too
Dumb(tm) to know that nothing's actually changed. i'll take a look in a bit
about th
Hi,
Testing python applet and noticed that configChanged is not forwarded to
python applets (attached diff).
Currently configChanged is called multiple times at start and at config dialog
close. Should Plasma take care of calling configChanged just once in these
situations?
plasmoidviewer
52 matches
Mail list logo
