Re: api review for DataEngineConsumer

2012-09-25 Thread Marco Martin
On Tue, Sep 25, 2012 at 9:36 AM, Aaron J. Seigo wrote: > On Monday, September 24, 2012 21:09:57 Marco Martin wrote: >> rationale to remove remoteDataEngine > > the difference between dataEngine and remoteDataEngine was passing a QUrl for > the remote engine. it seemed natural to merge the two thin

Re: api review for DataEngineConsumer

2012-09-25 Thread Aaron J. Seigo
On Monday, September 24, 2012 21:09:57 Marco Martin wrote: > rationale to remove remoteDataEngine the difference between dataEngine and remoteDataEngine was passing a QUrl for the remote engine. it seemed natural to merge the two things. not only does this give us just one method in the public A

Re: api review for DataEngineConsumer

2012-09-24 Thread Marco Martin
On Mon, Sep 24, 2012 at 4:26 PM, Aaron J. Seigo wrote: > turns out that this is how DataEngineManager was nearly *always* used, and > when it wasn't (e.g. in individual Applets) it often caused problems. problems > which DataEngineConsumer avoids. > > so ... in these changes to libplasma2, DataEng

api review for DataEngineConsumer

2012-09-24 Thread Aaron J. Seigo
hi... i just pushed DataEngineConsumer as public API in libplasma2. this class is used extensively in libplasma1 (and wherever it was copy and pasted ;) to make it easy to tie usage of DataEngineManager to the lifespan of a given object (such as Applet, Runner, etc.) turns out that this is how