Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 11:46 p.m.) Status -- This change has been m

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Kai Uwe Broulik
> On Okt. 10, 2016, 8:49 nachm., Kai Uwe Broulik wrote: > > This commit broke panel display/loading for me. > > > > When I have a system tray in a panel (eg. default panel) it won't show up > > on startup. Sorry, the REVIEW link in the commit was wrong. The offending commit is 2ed819f37dd44cc

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99915 --- This commit broke panel display/loading for me. When I have

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 2:30 p.m.) Status -- This change has been ma

Re: Review Request 129101: Port to new plasma-framework API

2016-10-06 Thread Marco Martin
> On Oct. 6, 2016, 2:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should r

Re: Review Request 129101: Port to new plasma-framework API

2016-10-06 Thread Aleix Pol Gonzalez
> On Oct. 6, 2016, 4:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should r

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99802 --- runners/windowedwidgets/windowedwidgetsrunner.cpp (line 107)

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma. Repositor

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma. Bugs: 129

Re: Review Request 129101: Port to new plasma-framework API

2016-10-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99792 --- Fix it, then Ship it! applets/systemtray/systemtray.cpp (

Re: Review Request 129101: Port to new plasma-framework API

2016-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 1:59 a.m.) Review request for Plasma. Repository

Re: Review Request 129101: Port to new plasma-framework API

2016-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 1:58 a.m.) Review request for Plasma. Repository

Re: Review Request 129101: Port to new plasma-framework API

2016-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99791 --- Fix it, then Ship it! shell/shellcorona.cpp (line 1964) <

Review Request 129101: Port to new plasma-framework API

2016-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- Review request for Plasma. Repository: plasma-workspace Description ---