Re: Review Request 128802: task bar lines

2016-09-26 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 26, 2016, 8:24 p.m.) Status -- This change has been m

Re: Review Request 128802: task bar lines

2016-09-10 Thread Kai Uwe Broulik
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

Re: Review Request 128802: task bar lines

2016-09-10 Thread Andreas Kainz
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

Re: Review Request 128802: task bar lines

2016-09-09 Thread Andreas Kainz
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

Re: Review Request 128802: task bar lines

2016-09-09 Thread David Rosca
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

Re: Review Request 128802: task bar lines

2016-09-09 Thread Marco Martin
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

Re: Review Request 128802: task bar lines

2016-09-09 Thread Marco Martin
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. yes, there should be a line fo

Re: Review Request 128802: task bar lines

2016-09-09 Thread Kai Uwe Broulik
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). Aw, crap. Right. For Icon Tasks there's no label for the active windows. - Kai Uwe

Re: Review Request 128802: task bar lines

2016-09-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review99025 --- You can't tell apart launcher and normal task now, they look

Re: Review Request 128802: task bar lines

2016-09-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 9, 2016, 1:20 p.m.) Status -- This change has been ma

Re: Review Request 128802: task bar lines

2016-09-05 Thread Marco Martin
> On Sept. 2, 2016, 8:15 a.m., Marco Martin wrote: > > no, don't like lines at the bottom for bottom panels at all, the whole > > point was to make it look the same as open plasmoids (which no, not going > > to change, at least not for 5.8). > > i would rather keep the current squares then. >

Re: Review Request 128802: task bar lines

2016-09-02 Thread Andreas Kainz
> On Sept. 2, 2016, 8:15 vorm., Marco Martin wrote: > > no, don't like lines at the bottom for bottom panels at all, the whole > > point was to make it look the same as open plasmoids (which no, not going > > to change, at least not for 5.8). > > i would rather keep the current squares then. >

Re: Review Request 128802: task bar lines

2016-09-02 Thread Marco Martin
> On Sept. 2, 2016, 8:15 a.m., Marco Martin wrote: > > no, don't like lines at the bottom for bottom panels at all, the whole > > point was to make it look the same as open plasmoids (which no, not going > > to change, at least not for 5.8). > > i would rather keep the current squares then. >

Re: Review Request 128802: task bar lines

2016-09-02 Thread Kai Uwe Broulik
> On Sept. 2, 2016, 8:15 vorm., Marco Martin wrote: > > no, don't like lines at the bottom for bottom panels at all, the whole > > point was to make it look the same as open plasmoids (which no, not going > > to change, at least not for 5.8). > > i would rather keep the current squares then. A

Re: Review Request 128802: task bar lines

2016-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98828 --- no, don't like lines at the bottom for bottom panels at all,

Re: Review Request 128802: task bar lines

2016-09-02 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 2, 2016, 7:16 vorm.) Review request for Plasma. Changes

Re: Review Request 128802: task bar lines

2016-09-02 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 2, 2016, 7:12 vorm.) Review request for Plasma. Reposito

Re: Review Request 128802: task bar lines

2016-09-01 Thread Andreas Kainz
> On Aug. 30, 2016, 10:57 nachm., Eike Hein wrote: > > Tech-wise I have no objections, the SVG looks clean. > > > > Design-wise I'm conflicted. Unlike the old implementation of the lines, > > this time no attempt was made to vert-center the content in the remaining > > negative space. This avo

Re: Review Request 128802: task bar lines

2016-08-31 Thread Andreas Kainz
> On Aug. 30, 2016, 10:57 nachm., Eike Hein wrote: > > Tech-wise I have no objections, the SVG looks clean. > > > > Design-wise I'm conflicted. Unlike the old implementation of the lines, > > this time no attempt was made to vert-center the content in the remaining > > negative space. This avo

Re: Review Request 128802: task bar lines

2016-08-30 Thread Eike Hein
> On Aug. 30, 2016, 10:57 p.m., Eike Hein wrote: > > Tech-wise I have no objections, the SVG looks clean. > > > > Design-wise I'm conflicted. Unlike the old implementation of the lines, > > this time no attempt was made to vert-center the content in the remaining > > negative space. This avoid

Re: Review Request 128802: task bar lines

2016-08-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98803 --- Ship it! Tech-wise I have no objections, the SVG looks cle

Re: Review Request 128802: task bar lines

2016-08-30 Thread Eike Hein
> On Aug. 30, 2016, 10:30 p.m., Eike Hein wrote: > > I can't seem to review this because the patch doesn't contain the changed > > binary file. I was unable to download the svgz from the web UI or via > > reviewboard-am. I don't know if Reviewboard supports any patch format with > > binary con

Re: Review Request 128802: task bar lines

2016-08-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98799 --- I can't seem to review this because the patch doesn't contain

Re: Review Request 128802: task bar lines

2016-08-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 30, 2016, 3:54 p.m.) Review request for Plasma. Changes -

Re: Review Request 128802: task bar lines

2016-08-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 30, 2016, 2:22 p.m.) Review request for Plasma. Changes -

Re: Review Request 128802: task bar lines

2016-08-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98791 --- +1 Perfect. (I would still like Eike to look over the margi

Re: Review Request 128802: task bar lines

2016-08-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 30, 2016, 2:04 p.m.) Review request for Plasma. Repositor

Re: Review Request 128802: task bar lines

2016-08-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 30, 2016, 2:03 p.m.) Review request for Plasma. Repositor

Re: Review Request 128802: task bar lines

2016-08-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 30, 2016, 2:02 p.m.) Review request for Plasma. Changes -

Re: Review Request 128802: task bar lines

2016-08-30 Thread Kai Uwe Broulik
> On Aug. 30, 2016, 8:43 vorm., Kai Uwe Broulik wrote: > > Nice work! > > > > Combining the best of both worlds, unintrusive lines where possible but > > filled background where needed. > > > > I like that the text somewhat "sits" on the line (top panel) but descenders > > of letters like "g"

Re: Review Request 128802: task bar lines

2016-08-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98786 --- Nice work! Combining the best of both worlds, unintrusive li

Re: Review Request 128802: task bar lines

2016-08-29 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98778 --- nice. I want to take a close look at the details of the SVG t

Re: Review Request 128802: task bar lines

2016-08-29 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review98777 --- Looks really nice! - Ivan Čukić On Aug. 29, 2016, 10:21 p.

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:20 p.m.) Review request for Plasma. Changes

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:21 p.m.) Review request for Plasma. Changes

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:20 p.m.) Review request for Plasma. Reposito

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:19 p.m.) Review request for Plasma. Changes

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:18 p.m.) Review request for Plasma. Changes

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:13 p.m.) Review request for Plasma. Reposito

Re: Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Aug. 29, 2016, 10:11 p.m.) Review request for Plasma. Reposito

Review Request 128802: task bar lines

2016-08-29 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- Review request for Plasma. Repository: plasma-framework Description ---