Re: Review Request 128761: Fix crash on exit

2016-10-11 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ --- (Updated Oct. 11, 2016, 6:34 p.m.) Status -- This change has been ma

Re: Review Request 128761: Fix crash on exit

2016-10-05 Thread Hugo Pereira Da Costa
On 10/04/2016 10:53 PM, Peter Wu wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ On August 27th, 2016, 12:25 p.m. CEST, *Hugo Pereira Da Costa* wrote: Ship It! Congratulations with the release of Plasma 5.8! It contains

Re: Review Request 128761: Fix crash on exit

2016-10-04 Thread Peter Wu
> On Aug. 27, 2016, 12:25 p.m., Hugo Pereira Da Costa wrote: > > Ship It! Congratulations with the release of Plasma 5.8! It contains the Breeze fix (yay!), but Oxygen is unfortunately lacking this patch. Could you merge it? Thanks! - Peter -

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98718 --- Calling exit() before deleting the QApplication is explicitly

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98712 --- Ship it! Ship It! - Hugo Pereira Da Costa On Aug. 27, 2

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Hugo Pereira Da Costa
> On Aug. 27, 2016, 9:14 a.m., Hugo Pereira Da Costa wrote: > > mmm. But then i think it is better (for commit history etc), to just revert > > the incriminated commit (and in oxygen as well), with a possible link to > > this RB. makes sense ? > > Peter Wu wrote: > I tested the reverts for

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Peter Wu
> On Aug. 27, 2016, 11:14 a.m., Hugo Pereira Da Costa wrote: > > mmm. But then i think it is better (for commit history etc), to just revert > > the incriminated commit (and in oxygen as well), with a possible link to > > this RB. makes sense ? I tested the reverts for breeze and oxygen and th

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98709 --- mmm. But then i think it is better (for commit history etc),

Re: Review Request 128761: Fix crash on exit

2016-08-27 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ --- (Updated Aug. 27, 2016, 11:12 a.m.) Review request for Plasma, David Edmu