Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-27 Thread Hugo Pereira Da Costa
> On Aug. 26, 2016, 4:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Anthony Fieroni
> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Anthony Fieroni
> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review98667 --- kstyle/breezestyleplugin.cpp (line 44)

Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-25 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira D