Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/ --- (Updated July 14, 2016, 11:04 a.m.) Status -- This change has been m

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote: > > Is there any status update on this commit? Should it be integrated? > > John Salatas wrote: > I'm done with it. Hopefully someone will commit to git as I don't have > commit rights in order to do it myself. i an commit it,

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote: > > Is there any status update on this commit? Should it be integrated? I'm done with it. Hopefully someone will commit to git as I don't have commit rights in order to do it myself. - John -

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97384 --- Is there any status update on this commit? Should it be integ

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 12, 2016, 11:40 a.m., Kai Uwe Broulik wrote: > > done - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97313 ---

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97313 --- applets/systemtray/package/contents/ui/main.qml (line 33)

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 12, 2016, 7:46 a.m., Marco Martin wrote: > > > > John Salatas wrote: > done I just realized that I cannot commit to git and (obviously) marking it as submitted it doesn't submit it :) Can someone submit it for me? Thanks! - John

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/ --- (Updated July 12, 2016, 8:29 a.m.) Status -- This change has been ma

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97308 --- Ship it! Ship It! - John Salatas On July 8, 2016, 8:56

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 12, 2016, 7:46 a.m., Marco Martin wrote: > > done - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97305 ---

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97305 --- Fix it, then Ship it! applets/systemtray/package/contents

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote: > > Visual aspects should stay under the theme's control. Therefore, from the > > usability perspective, there should be no user option, instead the look & > > feel theme should be able to control the icon size. > > John Salatas wrote: >

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote: > > Visual aspects should stay under the theme's control. Therefore, from the > > usability perspective, there should be no user option, instead the look & > > feel theme should be able to control the icon size. > > John Salatas wrote: >

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote: > > Visual aspects should stay under the theme's control. Therefore, from the > > usability perspective, there should be no user option, instead the look & > > feel theme should be able to control the icon size. I don't think that currently

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97212 --- Visual aspects should stay under the theme's control. Therefo

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 9:45 a.m., Heiko Tietze wrote: > > Please add a screenshot. But actually I wonder why size matters. Aren't > > icons adjusted according the panel height anymore? That would by a minus > > one. > > Kai Uwe Broulik wrote: > They are. For system tray only up to a certain po

Re: Review Request 128400: Configuration option for System Tray's icon size

> On Juli 8, 2016, 9:45 vorm., Heiko Tietze wrote: > > Please add a screenshot. But actually I wonder why size matters. Aren't > > icons adjusted according the panel height anymore? That would by a minus > > one. They are. For system tray only up to a certain point, though, at which it will b

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97202 --- Please add a screenshot. But actually I wonder why size matte

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

> On Juli 8, 2016, 7:21 vorm., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

> On Juli 8, 2016, 7:21 vorm., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > However, I don't think there should be such an option. There's no other > > applet which has this and applets in the panel usually follow the panel > > size indefinitely. Perhaps add the "usability" group t

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/ --- (Updated July 8, 2016, 8:41 a.m.) Review request for Plasma. Repository

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97191 --- I really don't want an option for this :( - Marco Martin O

Re: Review Request 128400: Configuration option for System Tray's icon size

> On Юли 8, 2016, 9:57 преди обяд, Anthony Fieroni wrote: > > About me, size of systray icons must depend on panel size. Same for space > > between items. > > John Salatas wrote: > Well... I guess it's just a matter of personal taste. I'm using a rather > high panel and the default icon si

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97186 --- Thanks for your patch! However, I don't think there should b

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 6:57 a.m., Anthony Fieroni wrote: > > About me, size of systray icons must depend on panel size. Same for space > > between items. Well... I guess it's just a matter of personal taste. I'm using a rather high panel and the default icon size (units.iconSizes.medium) seems rat

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97184 --- About me, size of systray icons must depend on panel size. Sa

Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/ --- Review request for Plasma. Repository: plasma-workspace Description ---