Re: Review Request 127864: Remove second list storing duplicate data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/ --- (Updated May 8, 2016, 12:56 p.m.) Status -- This change has been mar

Re: Review Request 127864: Remove second list storing duplicate data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/#review95277 --- Ship it! Thanks a lot! And thanks Mark for the review -

Re: Review Request 127864: Remove second list storing duplicate data

> On May 8, 2016, 10:49 a.m., Mark Gaiser wrote: > > Modules/energy/batterymodel.cpp, line 60 > > > > > > i=0 > > i = 0 (spaces, nitpick) > > > > However, in this block (where you just want to find 1

Re: Review Request 127864: Remove second list storing duplicate data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/ --- (Updated May 8, 2016, 12:20 p.m.) Review request for Plasma. Repository

Re: Review Request 127864: Remove second list storing duplicate data

> On mei 8, 2016, 10:49 a.m., Mark Gaiser wrote: > > Modules/energy/batterymodel.cpp, lines 33-38 > > > > > > just: > > m_batteries = > > Solid::Device::listFromType(Solid::DeviceInterface::Battery); > >

Re: Review Request 127864: Remove second list storing duplicate data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/#review95268 --- Modules/energy/batterymodel.cpp (lines 33 - 36)

Review Request 127864: Remove second list storing duplicate data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/ --- Review request for Plasma. Repository: kinfocenter Description ---