Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- (Updated April 13, 2016, 1:45 p.m.) Status -- This change has been m

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
> On April 13, 2016, 10:34 a.m., Kai Uwe Broulik wrote: > > Shouldn't QFormLayout do that? Yes, but it requires a more invasive patch (the layout of spacers/buttons is messed up if we just change QGridLayout to QFormLayout) - Elvis ---

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94574 --- Shouldn't QFormLayout do that? - Kai Uwe Broulik On April

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Jan Grulich
> On Dub. 13, 2016, 10:24 dop., Jan Grulich wrote: > > Perfect, looks good. Ship it!! > > Elvis Angelaccio wrote: > Maybe we could even consider this as a bugfix? And commit it to 5.6 > branch? I agree, it doesn't change any string or something like that so you can push it to Plasma/5.6 b

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
> On April 13, 2016, 10:24 a.m., Jan Grulich wrote: > > Perfect, looks good. Ship it!! Maybe we could even consider this as a bugfix? And commit it to 5.6 branch? - Elvis --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94571 --- Ship it! Perfect, looks good. Ship it!! - Jan Grulich O

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- (Updated April 13, 2016, 10:18 a.m.) Review request for Plasma and Jan Gr

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94569 --- Could you please provide screenshot for comparison? libs/ed

Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- Review request for Plasma and Jan Grulich. Repository: plasma-nm Descri