Re: Review Request 127616: Digital clock applet re-write

2017-02-08 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- (Updated Feb. 8, 2017, 12:41 p.m.) Status -- This change has been di

Re: Review Request 127616: Digital clock applet re-write

2017-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/#review102454 --- Sorry this got ignored, I think everyone was waiting on a re

Re: Review Request 127616: Digital clock applet re-write

2016-04-10 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/#review94473 --- applets/digital-clock/package/contents/ui/main.qml (line 128

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- (Updated April 9, 2016, 5:23 nachm.) Review request for Plasma. Bugs: 3

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
> On April 9, 2016, 2:22 nachm., Kai Uwe Broulik wrote: > > Nice cleanup work, haven't tried it so far, but a few nitpicks below. > > > > Also, you did a bunch of changes that were purely code-cosmetical, those > > should go into separate commits imho. > > > > Also, I think we should have a ne

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- (Updated April 9, 2016, 5:21 nachm.) Review request for Plasma. Bugs: 3

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/#review94456 --- Nice cleanup work, haven't tried it so far, but a few nitpick

Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127616/ --- Review request for Plasma. Bugs: 354239 and 360059 https://bugs.kde.o