Re: Review Request 127485: KCM: Add button to set default devices

2016-04-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated April 1, 2016, 8:47 a.m.) Status -- This change has been ma

Re: Review Request 127485: KCM: Add button to set default devices

2016-04-01 Thread David Rosca
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume keys

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Thomas Pfeiffer
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume keys

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Kai Uwe Broulik
> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume key

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Xuetian Weng
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume keys

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Kai Uwe Broulik
> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume key

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Xuetian Weng
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume keys

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review94160 --- Ship it! Ship It! - Sebastian Kügler On March 24, 2016,

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated March 24, 2016, 9:52 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread Kai Uwe Broulik
> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume key

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread David Rosca
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume keys

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review93950 --- I like the RadioButton but it should say "Default" or "Defaul

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread Thomas Pfeiffer
> On March 24, 2016, 8:47 p.m., Thomas Pfeiffer wrote: > > Three visually independent pushbuttons to not indicate a selection. > > Why don't you use radio buttons? > > David Rosca wrote: > > Three visually independent pushbuttons to not indicate a selection. > > That's a bug in Bree

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated March 24, 2016, 9:08 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread David Rosca
> On March 24, 2016, 8:47 p.m., Thomas Pfeiffer wrote: > > Three visually independent pushbuttons to not indicate a selection. > > Why don't you use radio buttons? > Three visually independent pushbuttons to not indicate a selection. That's a bug in Breeze - it draws checked button same as sele

Re: Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review93944 --- Three visually independent pushbuttons to not indicate a sele

Review Request 127485: KCM: Add button to set default devices

2016-03-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- Review request for Plasma and KDE Usability. Repository: plasma-pa Desc