Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/ --- (Updated Feb. 29, 2016, 1:27 p.m.) Status -- This change has been ma

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote: > > src/plasma/applet.h, line 463 > > > > > > Better explain the parameter reason here rather than in the getter the text for reason is just copypasted in bo

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92904 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 29, 2016, 1

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 644 > > > > > > I think this is not optimal overall: > > > > Imagine you set both proper

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92905 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (line 655

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92902 --- src/plasma/applet.h (line 463)

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/ --- (Updated Feb. 29, 2016, 12:39 p.m.) Review request for Plasma. Reposito

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 12:19 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76 > > > > > > why copy the string? > > Kai Uwe Broulik wrote: > We need a getter for th

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 12:19 nachm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76 > > > > > > why copy the string? We need a getter for this. - Kai Uwe -

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92895 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (lines 75

Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/ --- Review request for Plasma. Repository: plasma-framework Description ---