Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/ --- (Updated Feb. 11, 2016, 5:49 p.m.) Status -- This change has been ma

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Aleix Pol Gonzalez
> On Feb. 6, 2016, 12:22 a.m., David Edmundson wrote: > > imports/activitymanager/switcherbackend.cpp, line 125 > > > > > > this isn't identical. > > > > old code would match alt+shift+tab, yours doesn't

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/#review92261 --- Ship it! Looks ok - Ivan Čukić On Feb. 8, 2016, 2:03 a.

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/ --- (Updated Feb. 8, 2016, 3:03 a.m.) Review request for Plasma and Ivan Čuki

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-07 Thread Aleix Pol Gonzalez
> On Feb. 6, 2016, 12:22 a.m., David Edmundson wrote: > > imports/activitymanager/switcherbackend.cpp, line 125 > > > > > > this isn't identical. > > > > old code would match alt+shift+tab, yours doesn't

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/#review92109 --- Fix it, then Ship it! One minor question imports/activit

Review Request 126996: Drop usage of Qt4Support

2016-02-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/ --- Review request for Plasma. Repository: plasma-desktop Description -