Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/ --- (Updated Feb. 8, 2016, 1:03 p.m.) Status -- This change has been mar

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Aleix Pol Gonzalez
> On Feb. 8, 2016, 10:29 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 52 > > > > > > onStatusChanged: { > > if (status === Loader.Ready) > > > > ? > > Kai Uwe

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Marco Martin
> On Feb. 8, 2016, 9:29 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 52 > > > > > > onStatusChanged: { > > if (status === Loader.Ready) > > > > ? > > Kai Uwe

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Kai Uwe Broulik
> On Feb. 8, 2016, 9:29 vorm., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 52 > > > > > > onStatusChanged: { > > if (status === Loader.Ready) > > > > ? > > Kai Uwe

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Aleix Pol Gonzalez
> On Feb. 8, 2016, 10:29 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 52 > > > > > > onStatusChanged: { > > if (status === Loader.Ready) > > > > ? > > Kai Uwe

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review92153 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 52)

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Kai Uwe Broulik
> On Feb. 8, 2016, 9:29 vorm., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 52 > > > > > > onStatusChanged: { > > if (status === Loader.Ready) > > > > ? Also, why n

Re: Review Request 126962: Animate lock screen initialization

2016-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review92149 --- Ship it! Ship It! - Marco Martin On Feb. 8, 2016, 3:24

Re: Review Request 126962: Animate lock screen initialization

2016-02-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/ --- (Updated Feb. 8, 2016, 4:24 a.m.) Review request for Plasma. Changes --

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 7:34 p.m., Marco Martin wrote: > > h, wait!!one!It's animated already, you are animating it two times :) > > look at LookScreenUi.qml. > > it's already fading in. It's not visible because it was units.shortDuration > > and that is a moment of high CPU load so frames are sk

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91987 --- h, wait!!one!It's animated already, you are animating it

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91981 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 55)

Re: Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/#review91978 --- Ship it! Ship It! - Martin Gräßlin On Feb. 2, 2016, 4:1

Review Request 126962: Animate lock screen initialization

2016-02-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126962/ --- Review request for Plasma. Repository: plasma-workspace Description ---