Re: Review Request 126807: Ensure connection to exist before using

2016-01-21 Thread Andreas Cord-Landwehr
> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad

Re: Review Request 126807: Ensure connection to exist before using

2016-01-21 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 21, 2016, 8:55 nachm.) Status -- This change has been

Re: Review Request 126807: Ensure connection to exist before using

2016-01-20 Thread Xuetian Weng
> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126807: Ensure connection to exist before using

2016-01-20 Thread Andreas Cord-Landwehr
> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Xuetian Weng
> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Rajeesh K V
Hi Weng Xeutian, Any ideas on the below mentioned issue? On Tue, Jan 19, 2016 at 8:09 PM, Rajeesh K V wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126807/ > > On January 19th, 2016, 6:35 p.m. UTC, *Rajeesh K V* wrote: > > I must admit

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Rajeesh K V
> On Jan. 19, 2016, 6:35 p.m., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad h

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Andreas Cord-Landwehr
> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. If I am not mistaken, the root cause is the following: * XLibTouchpad has a member variable m_touchpadOffAtom * th

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Rajeesh K V
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/#review91343 --- Ship it! I must admit I don't understand the root cause or

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/#review91323 --- FWIW, fixes the issue for me. I'm clueless about whether it's

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 19, 2016, 10:24 a.m.) Review request for Plasma and Alexand

Re: Review Request 126807: Ensure connection to exist before using

2016-01-19 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 19, 2016, 9:18 vorm.) Review request for Plasma and Alexand