Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- (Updated Jan. 19, 2016, 5:02 p.m.) Status -- This change has been ma

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91339 --- Ship it! Ship It! - David Edmundson On Jan. 19, 2016, 4

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
> On Jan. 19, 2016, 3:07 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/AppletConfiguration.qml, line 168 > > > > > > don't set width in a child of a Layout > > > > the layout wil

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- (Updated Jan. 19, 2016, 4:12 p.m.) Review request for Plasma. Changes -

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91331 --- desktoppackage/contents/configuration/AppletConfiguration.qm

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Edmundson
> On Jan. 19, 2016, 8:51 a.m., Marco Martin wrote: > > sure it's not just hiding it? > > some times if you do the syncing by javascript it goes undetected and you > > fin yourself with 100% cpu without knowing why > > David Rosca wrote: > That's possible, but I can't see any problems with c

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread David Rosca
> On Jan. 19, 2016, 8:51 a.m., Marco Martin wrote: > > sure it's not just hiding it? > > some times if you do the syncing by javascript it goes undetected and you > > fin yourself with 100% cpu without knowing why That's possible, but I can't see any problems with cpu usage. The other fix is

Re: Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91314 --- sure it's not just hiding it? some times if you do the syncin

Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- Review request for Plasma. Repository: plasma-desktop Description -