Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/ --- (Updated Jan. 18, 2016, 3:48 p.m.) Status -- This change has been ma

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91270 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 18, 2016, 3

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/main.qml, line 103 > > > > > > I think you can unset Plasma's default thing by setting height to > > undefined (Q

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/main.qml, line 103 > > > > > > I think you can unset Plasma's default thing by setting height to > > undefined (Q

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/ --- (Updated Jan. 18, 2016, 3:26 p.m.) Review request for Plasma. Changes -

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml, line 88 > > > > > > onCheckedChanged ? No, it should be executed only when the checkbox value i

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 --- +1 applets/quicklaunch/package/contents/ui/ConfigGeneral.qm

Review Request 126786: Quicklaunch: Add option to show title

2016-01-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---