Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-08 Thread Dāvis Mosāns
> On Jan. 10, 2016, 3:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. > > David Kahles wrote: > I talked to them (see https://codereview.qt-project.org/#/c/144823/) and > it seems like we shouldn't hav

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-08 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126691/ --- (Updated Feb. 8, 2016, 11:56 p.m.) Status -- This change has been ma

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Kahles
> On Jan. 10, 2016, 2:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. > > David Kahles wrote: > I talked to them (see https://codereview.qt-project.org/#/c/144823/) and > it seems like we shouldn't hav

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Edmundson
> On Jan. 10, 2016, 1:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. > > David Kahles wrote: > I talked to them (see https://codereview.qt-project.org/#/c/144823/) and > it seems like we shouldn't hav

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126691/#review92129 --- Ship it! Ship It! - David Edmundson On Jan. 10, 2016, 1

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Kahles
> On Jan. 10, 2016, 2:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. I talked to them (see https://codereview.qt-project.org/#/c/144823/) and it seems like we shouldn't have done it like it was before, it

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126691/#review90839 --- That sounds like you're saying Qt has broken API. If that's t

Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-01-09 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126691/ --- Review request for Plasma. Repository: plasma-workspace Description ---