Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 11, 2016, 5:01 p.m.) Status -- This change has been ma

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90874 --- Ship it! looks good to me - Marco Martin On Jan. 10, 2016,

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-11 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90868 --- +1 - Mark Gaiser On jan 10, 2016, 10:03 p.m., Kai Uwe Broul

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90857 --- +1 Though wait for Marco as I don't know this code at all -

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 10:03 nachm.) Review request for Plasma. Change

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90848 --- src/declarativeimports/core/datamodel.cpp (line 466)

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 8:59 nachm.) Review request for Plasma. Changes

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 8:55 nachm.) Review request for Plasma. Changes

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90843 --- src/declarativeimports/core/datamodel.cpp (line 463)

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 5:10 nachm.) Review request for Plasma. Reposit

Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- Review request for Plasma. Repository: plasma-framework Description ---