Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/ --- (Updated Dec. 29, 2015, 4:29 p.m.) Status -- This change has been ma

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
> On Dec. 29, 2015, 3:22 p.m., David Edmundson wrote: > > src/plasmaquick/packageurlinterceptor.cpp, line 93 > > > > > > why the +1? > > > > is it that canonicalFilePath not leave a trailing slash which w

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/#review90291 --- Ship it! Thanks for looking into this. src/plasmaquick/pack

Re: Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/#review90290 --- Ship it! Ship It! - Marco Martin On Dec. 29, 2015, 3:08 p.

Review Request 126562: Deal properly with symlinks in path to packages

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126562/ --- Review request for Plasma. Repository: plasma-framework Description ---