Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 11:37 a.m.) Status -- This change has been m

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90204 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2015, 9:59 a.

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 9:59 a.m.) Review request for Plasma. Repositor

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 9:58 a.m.) Review request for Plasma. Repositor

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread David Edmundson
> On Dec. 28, 2015, 9:20 a.m., Marco Martin wrote: > > Did you try if particular options are used, like a different shell, > > plasmashell gets restarted with the same ones, same shell plugin? It does. - David --- This is an automatica

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread Bhushan Shah
> On Dec. 28, 2015, 2:42 a.m., David Edmundson wrote: > > shell/main.cpp, line 97 > > > > > > oh, I probably want to keep this and set the flag as appropriate. Yep it is useful. - Bhushan

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90193 --- Did you try if particular options are used, like a different s

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90184 --- shell/main.cpp

Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- Review request for Plasma. Repository: plasma-workspace Description ---