Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126349/ --- (Updated Dec. 15, 2015, 1:15 p.m.) Status -- This change has been di

Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126349/#review89522 --- i would prefer as well using gridUnit for the default panel th

Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-14 Thread Sebastian Kügler
> On Dec. 14, 2015, 6:36 p.m., David Edmundson wrote: > > Lets put it in the same place as gridUnit which is currently in > > scriptengine.cpp > > > > > > Whilst it's worth exporting this, is using gridUnit not the the most Plasma > > approach to solving the panel problem? > > Eike Hein wrot

Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126349/#review89500 --- The idea is that gridUnit looks at the current screen "the cod

Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-14 Thread Eike Hein
> On Dec. 14, 2015, 6:36 p.m., David Edmundson wrote: > > Lets put it in the same place as gridUnit which is currently in > > scriptengine.cpp > > > > > > Whilst it's worth exporting this, is using gridUnit not the the most Plasma > > approach to solving the panel problem? Possibly, but I do

Re: Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126349/#review89486 --- Lets put it in the same place as gridUnit which is currently i

Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

2015-12-14 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126349/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa