Re: Review Request 125973: Remove completely duplicated function

2016-01-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- (Updated Jan. 19, 2016, 12:22 p.m.) Status -- This change has been m

Re: Review Request 125973: Remove completely duplicated function

2015-11-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/#review88386 --- Ship it! Ship It! - Kai Uwe Broulik On Nov. 13, 2015, 12:1

Re: Review Request 125973: Remove completely duplicated function

2015-11-15 Thread David Edmundson
> On Nov. 14, 2015, 10:52 p.m., Kai Uwe Broulik wrote: > > On some items (clipboard widget, battery, kde connect, doesn't matter if > > entry hidden or shown) I also get panel options in the context menu whereas > > on the rest (plasma-pa, ktp-contact-list, plasma-nm, ...) I only get > > systr

Re: Review Request 125973: Remove completely duplicated function

2015-11-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/#review88365 --- On some items (clipboard widget, battery, kde connect, doesn't

Re: Review Request 125973: Remove completely duplicated function

2015-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- (Updated Nov. 13, 2015, 12:19 p.m.) Review request for Plasma. Reposito

Re: Review Request 125973: Remove completely duplicated function

2015-11-12 Thread David Edmundson
> On Nov. 10, 2015, 2:53 a.m., Martin Klapetek wrote: > > By the duplicated function you mean PlasmoidTask::showMenu(int x, int y)? > > That one has only two args and is missing the "run associated application" > > action, which I'm not entirely sure what's it used for. The rest indeed > > loo

Re: Review Request 125973: Remove completely duplicated function

2015-11-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/#review88210 --- By the duplicated function you mean PlasmoidTask::showMenu(int

Review Request 125973: Remove completely duplicated function

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- Review request for Plasma. Repository: plasma-workspace Description ---