Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/ --- (Updated Oct. 5, 2015, 3 p.m.) Status -- This change has been marked

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/#review86381 --- Ship it! Ship It! - David Edmundson On Oct. 5, 2015, 2:48

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread Christoph Cullmann
> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 156 > > > > > > just QGuiApplication::screens() should be fine here. > > Christoph Cullmann wrote: > Hmm, is then the

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/ --- (Updated Oct. 5, 2015, 2:48 p.m.) Review request for Plasma and Marco Mar

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread David Edmundson
> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 156 > > > > > > just QGuiApplication::screens() should be fine here. > > Christoph Cullmann wrote: > Hmm, is then the

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread Christoph Cullmann
> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 156 > > > > > > just QGuiApplication::screens() should be fine here. Hmm, is then there not a regression that we look at

Re: Review Request 125528: Check for nullptr screen

2015-10-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/#review86371 --- Thanks for looking into this. src/plasmaquick/dialog.cpp (li

Review Request 125528: Check for nullptr screen

2015-10-05 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/ --- Review request for Plasma and Marco Martin. Bugs: 345173 http://bugs.