Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 11, 2015, 3:54 p.m.) Status -- This change has been m

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84954 --- Ship it! dataengines/time/timeengine.cpp (line 27)

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 7, 2015, 12:10 p.m.) Review request for Plasma. Reposito

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread David Edmundson
> On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote: > > Have you tested this? Does the notification work with the zero timer? yes. I ran sudo timedatectl set-time 22:53 and watched the clock change and the debug appear. > On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote: > > dataengines/t

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84792 --- Have you tested this? Does the notification work with the zero

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 3, 2015, 9:36 a.m.) Review request for Plasma. Repositor

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84759 --- +1, modulo ifdefs - Marco Martin On Sept. 2, 2015, 10:29 a.

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-02 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84757 --- Looks good to me dataengines/time/timeengine.cpp (line 32) <

Review Request 125028: Monitor for the clock changes from the kernel

2015-09-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- Review request for Plasma. Repository: plasma-workspace Description ---