Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > > Martin

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > > Martin

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Gräßlin
> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > > Martin

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows ack, there's a new message that we're not catching. I don't know what the string is though. - David

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. I was thin

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review92059 --- FYI, This may not entirely work as https://bugs.kde.org/show_

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-10 Thread David Edmundson
> On Aug. 10, 2015, 7:02 a.m., Martin Gräßlin wrote: > > Could you add a call to > > > > QCoreApplication::setAttribute(Qt::AA_ForceRasterWidgets); > > > > before showing the warning message - just to be sure that it doesn't try > > creating another GL context and dies on it. on it, thanks

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83634 --- Could you add a call to QCoreApplication::setAttribute(Qt::AA

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread David Edmundson
> On Aug. 1, 2015, 11:48 a.m., Martin Klapetek wrote: > > shell/main.cpp, line 44 > > > > > > Just now I've read the actual message, "Please confirm your drivers" > > has two issues - a) it should mention graphic

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/ --- (Updated Aug. 1, 2015, 12:08 p.m.) Status -- This change has been ma

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83289 --- shell/main.cpp (line 44)

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread David Edmundson
> On Aug. 1, 2015, 9:46 a.m., Martin Klapetek wrote: > > shell/main.cpp, line 49 > > > > > > Does everything actually goes to stderr or should qDebug go to stdout? > > > > (I don't actually know but I alw

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review83285 --- Ship it! shell/main.cpp (line 4)

Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2015-08-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/ --- Review request for Plasma. Repository: plasma-workspace Description ---