Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-22 Thread David Edmundson
> On July 20, 2015, 9:10 p.m., David Edmundson wrote: > > Looks good to me. > > > > Do you have commit access? > > Eric Koegel wrote: > I don't have commit access, this is my first patch attempt for KDE. Cool, so the way it works is for the first 15 patches or so you upload to reviewboard

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-22 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 22, 2015, 5:37 p.m.) Status -- This change has been ma

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82827 --- Ship it! Ship It! - David Edmundson On July 22, 2015, 5:08

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-22 Thread Eric Koegel
> On July 20, 2015, 9:10 p.m., David Edmundson wrote: > > Looks good to me. > > > > Do you have commit access? I don't have commit access, this is my first patch attempt for KDE. - Eric --- This is an automatically generated e-mail. To

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-22 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 22, 2015, 5:08 p.m.) Review request for Plasma and Solid.

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Martin Gräßlin
> On July 20, 2015, 8:22 a.m., Martin Gräßlin wrote: > > May I ask you a favor? Could you please try whether you can get > > kwin_wayland (drm/libinput) to work with consolekit2? That would be totally > > awesome! > > > > Of course I'm also interested in consolekit2 addons to screen locker if

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82731 --- Thanks! daemon/backends/upower/powerdevilupowerbackend.cpp (

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82730 --- Looks good to me. Do you have commit access? daemon/powerde

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Eric Koegel
> On July 20, 2015, 6:22 a.m., Martin Gräßlin wrote: > > May I ask you a favor? Could you please try whether you can get > > kwin_wayland (drm/libinput) to work with consolekit2? That would be totally > > awesome! > > > > Of course I'm also interested in consolekit2 addons to screen locker if

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 20, 2015, 2:04 p.m.) Review request for Plasma and Solid.

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82678 --- May I ask you a favor? Could you please try whether you can ge

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82640 --- Cool. Thanks for this. FYI we're hoping to drop the ConsoleKi

Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-19 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- Review request for Plasma and Solid. Repository: powerdevil Description