Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/ --- (Updated June 19, 2015, 9:34 p.m.) Status -- This change has been ma

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/#review81564 --- Ship it! Ship It! - Marco Martin On June 17, 2015, 4:24 p.

Re: Review Request 124112: Implement drag and drop for Trash applet

> On Juni 17, 2015, 7:36 nachm., Sebastian Kügler wrote: > > applets/trash/plugin/trashplugin.cpp, line 30 > > > > > > I think we still want to delete this one *somewhere*? >From the documentation: NOTE: A QObjec

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/#review81537 --- QFile::isWritable() is confusing, it falls back to QIODevice::

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/ --- (Updated Juni 17, 2015, 4:24 nachm.) Review request for Plasma. Changes

Re: Review Request 124112: Implement drag and drop for Trash applet

> On Juni 17, 2015, 3:51 nachm., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail > > Sebastian Kügler wrote: >

Re: Review Request 124112: Implement drag and drop for Trash applet

> On June 17, 2015, 3:51 p.m., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail > > Sebastian Kügler wrote: >

Re: Review Request 124112: Implement drag and drop for Trash applet

> On June 17, 2015, 3:51 p.m., Marco Martin wrote: > > looks good. > > I wonder if should be ckecked also that the urls are actual filesystem urls > > or if is fine to just blindlt trash everything thrown at it since if it's > > not a filesystem one should fail I think even isLocalFile() and i

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/#review81527 --- Ship it! looks good. I wonder if should be ckecked also that

Re: Review Request 124112: Implement drag and drop for Trash applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/ --- (Updated Juni 16, 2015, 6:32 nachm.) Review request for Plasma. Summary