Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/ --- (Updated May 6, 2015, 12:04 a.m.) Status -- This change has been mar

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Aleix Pol Gonzalez
> On May 6, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: > > LGTM, thanks for looking into this. > > > > The alternative David suggests also sounds good, maybe better but not by > > that much. > > Sebastian Kügler wrote: > Agree. I'll let the guard in as well, just to be super-safe that the

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
> On May 5, 2015, 10:57 p.m., Aleix Pol Gonzalez wrote: > > LGTM, thanks for looking into this. > > > > The alternative David suggests also sounds good, maybe better but not by > > that much. Agree. I'll let the guard in as well, just to be super-safe that the crash is gone (and not reintrodu

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/#review79931 --- Ship it! LGTM, thanks for looking into this. The alternative

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/#review79923 --- Ship it! Good stuff :) shell/shellcorona.cpp (line 189)

Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/ --- Review request for Plasma. Bugs: 346590 https://bugs.kde.org/show_bug