Re: Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin
> On April 2, 2015, 2:23 p.m., David Edmundson wrote: > > +1. > > > > I'd suggest not merging until after 5.9 is tagged given how finicky dialog > > tends to be. > > Marco Martin wrote: > ok, will push next week so superseded by gerrit version https://gerrit.vesnicky.cesnet.cz/r/#/c/438/

Re: Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- (Updated April 2, 2015, 2:53 p.m.) Status -- This change has been di

Re: Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin
> On April 2, 2015, 2:23 p.m., David Edmundson wrote: > > +1. > > > > I'd suggest not merging until after 5.9 is tagged given how finicky dialog > > tends to be. ok, will push next week so - Marco --- This is an automatically generate

Re: Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/#review78408 --- +1. I'd suggest not merging until after 5.9 is tagged given h

Re: Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- (Updated April 2, 2015, 2 p.m.) Review request for Plasma. Bugs: 345787

Review Request 123227: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- Review request for Plasma. Bugs: 345787 http://bugs.kde.org/show_bug.