Re: Review Request 122795: Fix crashes when attempting to load invalid package

2017-02-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review102371 --- Patch does not apply anymore. - Albert Astals Cid On Marc

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76987 --- Ship it! Ship It! - Sebastian Kügler On March 3, 2015, 7:3

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Alex Richardson
> On March 3, 2015, 11:39 p.m., Aleix Pol Gonzalez wrote: > > Would it maybe be possible to get a unit test for the applet loading? I think all the crashes I got were due to https://git.reviewboard.kde.org/r/122733/. Now that that is fixed, the mainscript is always found. I'll try and create a

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76973 --- Would it maybe be possible to get a unit test for the applet l

Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor