Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-03-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated March 20, 2015, 2:04 p.m.) Status -- This change has been m

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-03-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review77726 --- Ship it! Ship It! - Marco Martin On March 4, 2015, 1 p.m.,

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-03-04 Thread Martin Gräßlin
> On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote: > > Can this be configured? I for sure don't want to be sending all my > > surroundings "somewhere" > > Martin Gräßlin wrote: > Yes it probably even has to be configured. I think we need to present the > "privacy contract" of the servi

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-03-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated March 4, 2015, 2 p.m.) Review request for Plasma, Jan Grulich an

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-28 Thread Jan Grulich
> On Úno. 27, 2015, 9:42 dop., Jan Grulich wrote: > > dataengines/geolocation/location_ip.cpp, line 149 > > > > > > SSID is never empty (at least it shouldn't be), if it would be a hidden > > AP it wouldn't be l

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-28 Thread Jan Grulich
> On Úno. 27, 2015, 9:42 dop., Jan Grulich wrote: > > dataengines/geolocation/location_ip.cpp, line 149 > > > > > > SSID is never empty (at least it shouldn't be), if it would be a hidden > > AP it wouldn't be l

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
> On Feb. 27, 2015, 10:42 a.m., Jan Grulich wrote: > > dataengines/geolocation/location_ip.cpp, line 149 > > > > > > SSID is never empty (at least it shouldn't be), if it would be a hidden > > AP it wouldn't be

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
> On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote: > > Can this be configured? I for sure don't want to be sending all my > > surroundings "somewhere" Yes it probably even has to be configured. I think we need to present the "privacy contract" of the service and have the user acknowledge i

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76711 --- Can this be configured? I for sure don't want to be sending al

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76707 --- dataengines/geolocation/location_ip.cpp

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76704 --- dataengines/geolocation/location_ip.cpp

Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository: plasm