Re: Review Request 122500: Don't delete widgets directly when changing styles

2015-02-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/ --- (Updated Feb. 10, 2015, 1:47 p.m.) Status -- This change has been ma

Re: Review Request 122500: Don't delete widgets directly when changing styles

2015-02-10 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/#review75782 --- Ship it! Ship It! - Hugo Pereira Da Costa On Feb. 10, 2015

Re: Review Request 122500: Don't delete widgets directly when changing styles

2015-02-10 Thread David Edmundson
> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote: > > Although I have no objection against the change, I must admit I don't > > understand what's wrong with the current code, nor the actual description > > of the patch. > > "registerWidget may take an existing widget as a parameter. I

Re: Review Request 122500: Don't delete widgets directly when changing styles

2015-02-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/ --- (Updated Feb. 10, 2015, 1:25 p.m.) Review request for Plasma and Hugo Per