Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 11, 2015, 9:31 a.m.) Status -- This change has been ma

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 9, 2015, 2:33 p.m.) Review request for Plasma. Repository

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 9, 2015, 2:19 p.m.) Review request for Plasma. Changes --

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 5, 2015, 11:29 a.m.) Review request for Plasma. Repositor

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75410 --- Code is all fine. By default each of these shows nothing; sho

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:06 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 121 > > > > > > is this needed? > > > > a cycle function is declared twice and seems to

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 2:10 p.m.) Review request for Plasma. Repository

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75405 --- applets/systemmonitor/common/contents/ui/Applet.qml

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 164 > > > > > > what colour does the Plotter background default to? > > > > There's pote

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 1:59 p.m.) Review request for Plasma. Repository

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 153 > > > > > > I'm lost on something. > > > > Why do we have a component singleValuePlo

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75383 --- applets/systemmonitor/common/contents/ui/Applet.qml

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 12:26 p.m.) Review request for Plasma. Changes -

Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- Review request for Plasma. Repository: plasma-workspace Description ---