Re: Review Request 122392: Fix Klipper Performance issues

2017-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review102451 --- If this diff is still appropriate please reopen on http://ph

Re: Review Request 122392: Fix Klipper Performance issues

2017-02-08 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 8, 2017, 12:03 p.m.) Status -- This change has been di

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review76103 --- sorry for the delay. I was basically without Internet all of l

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-09 Thread Martin Gräßlin
> On Feb. 3, 2015, 8:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-09 Thread Filip Wieladek
> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 8, 2015, 5:08 p.m.) Review request for Plasma. Repository

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Martin Gräßlin
> On Feb. 3, 2015, 8:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
> On Feb. 3, 2015, 6:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75260 --- could you please split the review in a per-commit review? I fi

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Martin Gräßlin
> On Feb. 3, 2015, 7:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
> On Feb. 3, 2015, 6:57 a.m., Martin Gräßlin wrote: > > As I worked on that just yesterday: you cannot filter in a different thread > > as Klipper is not thread save. Please see > > https://git.reviewboard.kde.org/r/122382/ for how I solved the problem. I > > suggest to rebase the patch on top

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75255 --- As I worked on that just yesterday: you cannot filter in a dif

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 3, 2015, 6:27 a.m.) Review request for Plasma. Repository

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/ --- (Updated Feb. 2, 2015, 6:44 p.m.) Review request for Plasma. Summary (u