Re: Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122119/ --- (Updated Jan. 19, 2015, 4:46 nachm.) Status -- This change has been

Re: Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-19 Thread Aleix Pol Gonzalez
> On Jan. 18, 2015, 12:47 a.m., Aleix Pol Gonzalez wrote: > > The change looks off. Shouldn't this go to either the QQC theme or > > upstream? Changing from using Qt components to our own thing is kind of > > against what we've been working for. > > David Edmundson wrote: > I think this is

Re: Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122119/#review74312 --- +1 from me. - David Edmundson On Jan. 17, 2015, 11:36 p.m.,

Re: Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-19 Thread David Edmundson
> On Jan. 17, 2015, 11:47 p.m., Aleix Pol Gonzalez wrote: > > The change looks off. Shouldn't this go to either the QQC theme or > > upstream? Changing from using Qt components to our own thing is kind of > > against what we've been working for. I think this is the best we're going to get. It

Re: Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122119/#review74209 --- The change looks off. Shouldn't this go to either the QQC them

Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

2015-01-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122119/ --- Review request for Plasma. Repository: plasma-framework Description ---