Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 5, 2015, 10:42 vorm.) Status -- This change has been d

Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-04 Thread Martin Gräßlin
> On Jan. 3, 2015, 3:49 p.m., David Edmundson wrote: > > Adding a method to one class (DesktopView) to manipulate another an > > instance of another class (Dialog) whilst using nothing from DesktopView to > > me seems like poor API. > > > > I'd consider > > Q_INVOKABLE forceActiveFocus() on Pl

Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 3, 2015, 3:07 nachm.) Review request for Plasma and Martin

Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik
> On Jan. 3, 2015, 2:49 nachm., David Edmundson wrote: > > Adding a method to one class (DesktopView) to manipulate another an > > instance of another class (Dialog) whilst using nothing from DesktopView to > > me seems like poor API. > > > > I'd consider > > Q_INVOKABLE forceActiveFocus() on

Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73024 --- Adding a method to one class (DesktopView) to manipulate anoth

Re: Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73020 --- Ship it! Ship It! - Lukáš Tinkl On Led. 3, 2015, 3:35 odp.

Review Request 121806: Allow desktop shell to force a window active

2015-01-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- Review request for Plasma. Repository: plasma-workspace Description ---