Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/ --- (Updated Jan. 2, 2015, 12:01 p.m.) Status -- This change has been ma

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On des. 15, 2014, 10:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. > > Martin Gräßlin wrote: > what do you

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 11:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. > > Martin Gräßlin wrote: > what do you

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On des. 15, 2014, 10:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. > > Martin Gräßlin wrote: > what do you

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 11:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. what do you want the integration test to te

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/#review72103 --- Ship it! Code looks good. Could you perhaps add an integrat

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 1:39 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 428 > > > > > > AFAIK you don't need to pass "this" in the [] when you have "this" as > > the receive

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 2:39 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 428 > > > > > > AFAIK you don't need to pass "this" in the [] when you have "this" as > > the receive

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

> On Dec. 15, 2014, 2:39 p.m., David Edmundson wrote: > > So basically we have a named pipe and we we pass back the wID of the lock > > screen to ksld? > > > > I'm not sure what benefit we have from using Wayland as the protocol as > > opposed to a private p2p DBus session or just writing it o

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/#review72044 --- So basically we have a named pipe and we we pass back the wID

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/ --- (Updated Dec. 15, 2014, 10:29 a.m.) Review request for Plasma, Àlex Fiest